Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LF-4601 Fixed: KPI needs to be higher than table header #3634

Open
wants to merge 5 commits into
base: integration
Choose a base branch
from

Conversation

gursimran-singh
Copy link
Collaborator

@gursimran-singh gursimran-singh commented Dec 19, 2024

Description

If you have lots of animal type and click on overflow button(more), the box showing remaining animal types goes under the table header. Which is fixed in this PR.

Jira link: https://lite-farm.atlassian.net/browse/LF-4601

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Add lots of animal type if not there. Click on the more button. The popup now is above the table header.

  • Passes test case
  • UI components visually reviewed on desktop view
  • UI components visually reviewed on mobile view
  • Other (please explain)

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The precommit and linting ran successfully
  • I have added or updated language tags for text that's part of the UI
  • I have added "MISSING" for all new language tags to languages I don't speak
  • I have added the GNU General Public License to all new files

@gursimran-singh gursimran-singh requested review from a team as code owners December 19, 2024 17:47
@gursimran-singh gursimran-singh requested review from antsgar and Duncan-Brain and removed request for a team December 19, 2024 17:47
Copy link
Collaborator

@Duncan-Brain Duncan-Brain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gursimran-singh thanks for fixing this glad it was a quick fix!

Just looks like it needs to be updated to integration!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants