fix(Text#fromAttributed): Fix StyleRun assuming that the startIndex and length always exist
#862
+11
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…x` and `length` always exist In AttributedText, styleRuns may not always include the `startIndex` or `length` properties - If `startIndex` is missing, we assume the style applies from the beginning of the text - If `length` is missing, we assume the style applies to the entire text
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #850
Fixes #854
In AttributedText, styleRuns may not always include the
startIndexorlengthpropertiesstartIndexis missing, we assume the style applies from the beginning of the textlengthis missing, we assume the style applies to the entire textExample RawNode data:
{ "contentMetadataViewModel": { "metadataRows": [ { "metadataParts": [ { "text": { "content": "@pbsspacetime", "styleRuns": [ { "weightLabel": "FONT_WEIGHT_MEDIUM", "styleRunExtensions": { "styleRunColorMapExtension": { "colorMap": [ { "key": "USER_INTERFACE_THEME_LIGHT", "value": 4279440147 }, { "key": "USER_INTERFACE_THEME_DARK", "value": 4294967295 } ] } } } ] }, "enableTruncation": true } ] } ], "delimiter": "•" } }