Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Text#fromAttributed): Fix StyleRun assuming that the startIndex and length always exist #862

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(Text#fromAttributed): Fix StyleRun assuming that the startIndex and length always exist #862

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions src/parser/classes/misc/Text.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@ export default class Text {
static fromAttributed(data: AttributedText) {
const {
content,
styleRuns: style_runs,
commandRuns: command_runs,
attachmentRuns: attachment_runs
} = data;
Expand All @@ -66,6 +65,16 @@ export default class Text {
}
];

// In AttributedText, styleRuns may not always include the `startIndex` or `length` properties
// - If `startIndex` is missing, we assume the style applies from the beginning of the text
// - If `length` is missing, we assume the style applies to the entire text
// The following code ensures default values are provided for these properties
const style_runs = data.styleRuns?.map((run) => ({
...run,
startIndex: run.startIndex ?? 0,
length: run.length ?? content.length
}) as StyleRun & ResponseRun);

if (style_runs || command_runs || attachment_runs) {
if (style_runs) {
for (const style_run of style_runs) {
Expand Down Expand Up @@ -271,7 +280,7 @@ interface ResponseRun {
length: number;
}

interface StyleRun extends ResponseRun {
interface StyleRun extends Partial<ResponseRun> {
italic?: boolean;
weightLabel?: string;
strikethrough?: string;
Expand Down
Loading