Update HasRandomIDAndLegacyTimeBasedID.php - Album ID Generation (#2554)

* Update HasRandomIDAndLegacyTimeBasedID.php Modification of ID generation based on recommendation by associate who is a PHP developer. This will avoid having a hyphen at the end of URLs which seems to cause issues with certain apps/devices that do URL parsing. --------- Co-authored-by: ildyria <[email protected]>
LycheeOrg · Oct 4, 2024 · a50c04e · a50c04e
1 parent b71138f
commit a50c04e
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/app/Models/Extensions/HasRandomIDAndLegacyTimeBasedID.php b/app/Models/Extensions/HasRandomIDAndLegacyTimeBasedID.php
@@ -152,6 +152,12 @@ private function generateKey(): void
 		// As the number of bytes is divisible by 3, no trailing `=` occurs.
 		try {
 			$id = strtr(base64_encode(random_bytes(3 * RandomID::ID_LENGTH / 4)), '+/', '-_');
+			// Last character whould not be a - for some version of android.
+			// this will reduce the entropy and induce a slight bias but we are still
+			// above the birthday bounds.
+			if ($id[23] === '-') {
+				$id[23] = '0';
+			}
 		} catch (\Exception $e) {
 			throw new InsufficientEntropyException($e);
 		}