Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always split path in CExtractDialog. #537

Merged
merged 1 commit into from
Jan 1, 2025
Merged

Conversation

dinhngtu
Copy link
Contributor

Even if the archive name checkbox in CExtractDialog is not checked, NanaZip appends the archive name to its extraction path anyway. Fix this issue by always splitting the extraction path in NanaZip.Windows.

@MouriNaruto
Copy link
Member

Before I merge this PR, I hope you will follow my two suggestions.

  • Please save the source code files in UTF-8 with BOM to ensure that the Windows and MSVC toolchain read them in UTF-8.
  • I hope we can add the NanaZip modification mark when modifying the 7-Zip mainline source code for better mainline synchronization maintenance which can reduce the regression. Here is an example:
    // **************** NanaZip Modification Start ****************
    //static const char * const kCopyrightString = "\n7-Zip"
    // PROG_POSTFIX_2
    // " " MY_VERSION_CPU
    // " : " MY_COPYRIGHT_DATE "\n";
    static const char * const kCopyrightString = "\nNanaZip"
    PROG_POSTFIX_2
    " " MILE_PROJECT_VERSION_UTF8_STRING " (" MY_CPU_NAME ")"
    " : " "(c) M2-Team and Contributors. All rights reserved." "\n";
    // **************** NanaZip Modification End ****************

Kenji Mouri

Even if the archive name checkbox in CExtractDialog is not checked, NanaZip
appends the archive name to its extraction path anyway. Fix this issue by
always splitting the extraction path in NanaZip.Windows.
@MouriNaruto MouriNaruto merged commit a32520b into M2Team:main Jan 1, 2025
1 check passed
@dinhngtu dinhngtu deleted the splitpath branch January 1, 2025 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants