-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleaning up API docs #49
Conversation
Codecov Report
Additional details and impacted files |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking really good, few things
- move intro from API to landing page, put kit history into last paragraph
- link to UG Note: add link to https://userguide.mdanalysis.org/stable/examples/analysis/trajectory_similarity/clustering_ensemble_similarity.html on landing page (might eventually be merged but not right now)
- add quick intro paragraph to API section
I referenced the user guide, but it's not quite 1:1 since the user guide references the core library implementation. I suppose I'll just a note that since the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a page for the references. Clicking a reference does not go anywhere for me (eg on the first page "The package contains implementations of similarity measures between protein ensembles described in [1].") Something is not working with footcite.
Also move the (good!) paragraph with the link to the UG to the landing page.
I don't see the changes in the RTD build (neither see also box nor working refs). Did you check your build? https://mdaencore--49.org.readthedocs.build/en/49/#footcite-lindorfflarsen2009 |
@orbeckst Do a hard refresh |
Changes made in this Pull Request:
Fixes #42
Fixes #43
PR Checklist