Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaning up API docs #49

Merged
merged 6 commits into from
Nov 8, 2023
Merged

Cleaning up API docs #49

merged 6 commits into from
Nov 8, 2023

Conversation

ianmkenney
Copy link
Member

@ianmkenney ianmkenney commented Nov 3, 2023

Changes made in this Pull Request:

  • API docs recreated to look more like original documentation from the core library

Fixes #42
Fixes #43

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Merging #49 (60f151d) into main (3da55f8) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

❗ Current head 60f151d differs from pull request most recent head 0577d58. Consider uploading reports for the commit 0577d58 to get more accurate results

Additional details and impacted files

@orbeckst
Copy link
Member

orbeckst commented Nov 6, 2023

Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking really good, few things

  1. move intro from API to landing page, put kit history into last paragraph
  2. link to UG Note: add link to https://userguide.mdanalysis.org/stable/examples/analysis/trajectory_similarity/clustering_ensemble_similarity.html on landing page (might eventually be merged but not right now)
  3. add quick intro paragraph to API section

@ianmkenney
Copy link
Member Author

I referenced the user guide, but it's not quite 1:1 since the user guide references the core library implementation. I suppose I'll just a note that since the encore module hasn't been removed, that you need to modify the imports. Want to just state the explicitly here.

@ianmkenney ianmkenney requested a review from orbeckst November 7, 2023 17:29
Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a page for the references. Clicking a reference does not go anywhere for me (eg on the first page "The package contains implementations of similarity measures between protein ensembles described in [1].") Something is not working with footcite.

Also move the (good!) paragraph with the link to the UG to the landing page.

docs/source/api.rst Outdated Show resolved Hide resolved
@ianmkenney ianmkenney requested a review from orbeckst November 8, 2023 16:38
@orbeckst
Copy link
Member

orbeckst commented Nov 8, 2023

I don't see the changes in the RTD build (neither see also box nor working refs). Did you check your build?

https://mdaencore--49.org.readthedocs.build/en/49/#footcite-lindorfflarsen2009

image

@ianmkenney
Copy link
Member Author

I don't see the changes in the RTD build (neither see also box nor working refs). Did you check your build?

https://mdaencore--49.org.readthedocs.build/en/49/#footcite-lindorfflarsen2009

image

@orbeckst Do a hard refresh

@orbeckst orbeckst merged commit e6364ba into main Nov 8, 2023
22 checks passed
@orbeckst orbeckst deleted the apidocs branch November 8, 2023 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOCS] links to functions/classes are non-existent docs are missing content from MDAnalysis.analysis.encore
2 participants