Encore Windows type fix #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original commit message by @tylerjereddy * in NumPy `2.0.0`, the default integer size on Windows will be 64-bit; we have 10 related test failures on Windows alongside NumPy `main` at the moment, and this patch fixes those failures by forcing a reversion to the old behavior, effectively kicking the can down the road * I think we're going to proceed with a similar solution upstream for now (i.e., scipy/scipy#19605 (comment));
tylerjereddy
approved these changes
Dec 24, 2023
|
Thanks @tylerjereddy ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original commit message by @tylerjereddy:
in NumPy
2.0.0, the default integer size on Windows will be 64-bit; we have 10 related test failures on Windows alongside NumPymainat the moment, and this patch fixes those failures by forcing a reversion to the old behavior, effectively kicking the can down the roadI think we're going to proceed with a similar solution upstream for now (i.e., BUG: wheel runs have a *lot* of test fails at the moment. scipy/scipy#19605 (comment));
Fixes #59
PR Checklist