-
Notifications
You must be signed in to change notification settings - Fork 666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nongaussian parameter #3896
Open
jaclark5
wants to merge
18
commits into
MDAnalysis:develop
Choose a base branch
from
jaclark5:nongaussian
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Nongaussian parameter #3896
Changes from 5 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
c701aaa
Added nongaussian parameter to simple msd calculation
jaclark5 2f5abd0
Merge branch 'develop' into nongaussian
jaclark5 243a52b
msd.py, bug fix nongaussian parameter, added versionchanged
jaclark5 b6dba74
Added tests for nongaussian parameter
jaclark5 49c42ca
Update CHANGELOG
jaclark5 31ec212
Update test, docs, add optional use for nongaussian parameter
jaclark5 1b05f0f
Merge branch 'develop' into nongaussian
jaclark5 27ee727
Updated doc and default value for nongaussian parameter
jaclark5 6dd7cba
Update test_msd kwargs
jaclark5 10fd87d
Address review comments
jaclark5 2dc04a8
Adjust msd doc strings and tests
jaclark5 278924f
Update docs and adherence to pep8
jaclark5 9d33765
Adherence of test_msd.py with pep8
jaclark5 e83a509
Merge branch 'develop' into nongaussian
jaclark5 d81733d
Merge branch 'develop' into nongaussian
jaclark5 c6c3368
Merge branch 'develop' into nongaussian
jaclark5 ed0c704
Merge branch 'develop' into nongaussian
jaclark5 6d91004
Merge branch 'develop' into nongaussian
jaclark5 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to make the parameter an optional addition to the
fft=False
run. MSDs are already expensive (esp without an FFT) and tacking on more compulsory computation is not ideal. Much better to have it as an optional kwarg.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough, that also begs the question on whether this package will move toward cython modules?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for the MSD package? There is likely some benefit there. We are generally encouraging of Cython contributions and have a bunch of extensions already written in Cython.
If you go down the cython side and need a hand feel free to ping. See setup.py for the minimal setup for a cython extension.