Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run all linters and fix files #4322

Closed

Conversation

jandom
Copy link
Contributor

@jandom jandom commented Oct 20, 2023

Auto-generated, companion to PR #4321

Changes made in this Pull Request:

  • run some basic linters

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

Developers certificate of origin


📚 Documentation preview 📚: https://mdanalysis--4322.org.readthedocs.build/en/4322/

@github-actions
Copy link

Linter Bot Results:

Hi @jandom! Thanks for making this PR. We linted your code and found the following:

Some issues were found with the formatting of your code.

Code Location Outcome
main package ⚠️ Possible failure
testsuite ⚠️ Possible failure

Please have a look at the darker-main-code and darker-test-code steps here for more details: https://github.com/MDAnalysis/mdanalysis/actions/runs/6592004268/job/17911771881


Please note: The black linter is purely informational, you can safely ignore these outcomes if there are no flake8 failures!

@orbeckst
Copy link
Member

Holy cr*p... anything that touches 327 files will require a teeny-weeny bit of discussion. Start with an issue to discuss the whole approach, see my #4321 (comment) .

@jandom
Copy link
Contributor Author

jandom commented Nov 5, 2023

don't think i'll be able to complete this in the coming month or so, so i'm closing for better visibility. will hopefully re-open in the future.

@jandom jandom closed this Nov 5, 2023
@jandom jandom deleted the jandom/feat/run-pre-commit-config branch November 11, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants