Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deploy to use the right environment & token permissions #4328

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

IAlibay
Copy link
Member

@IAlibay IAlibay commented Oct 27, 2023

Follows up from #4325

I didn't see what we needed to set the environment url & token permissions, so doing so now.

This does load to some annoying proliferation of action steps, I'll probably create a reusable action at some point, but for now this will do.

Developers certificate of origin


📚 Documentation preview 📚: https://mdanalysis--4328.org.readthedocs.build/en/4328/

@github-actions
Copy link

Linter Bot Results:

Hi @IAlibay! Thanks for making this PR. We linted your code and found the following:

There are currently no issues detected! 🎉

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (707e043) 93.37% compared to head (8b9c22a) 93.37%.

Additional details and impacted files
@@            Coverage Diff             @@
##           develop    #4328     +/-   ##
==========================================
  Coverage    93.37%   93.37%             
==========================================
  Files          170      184     +14     
  Lines        22295    23403   +1108     
  Branches      4075     4075             
==========================================
+ Hits         20818    21853   +1035     
- Misses         962     1035     +73     
  Partials       515      515             

see 14 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IAlibay IAlibay requested a review from orbeckst October 31, 2023 07:06
Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, lgtm as far as I can tell.

(I agree with you: it would be nice to reduce code duplication eventually for the [package, tests] x [testpypi, pypi] deployment matrix.)

@IAlibay IAlibay merged commit 4b8b924 into develop Oct 31, 2023
25 checks passed
@IAlibay IAlibay deleted the fix-deploy branch October 31, 2023 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants