scipy.integrate.simps deprecation #4330
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
2023-11-03T03:16:21.1314426Z /home/runner/work/mdanalysis/mdanalysis/package/MDAnalysis/analysis/pca.py:750: DeprecationWarning: 'scipy.integrate.simps' is deprecated in favour of 'scipy.integrate.simpson' and will be removed in SciPy 1.14.0
In this PR
Switch to scipy.integrate.simpson - note that the
even
keyword now defaults to Simpson's rule compared toavg
in scipy.integrate.simps.As the
even
keyword is deprecated and soon to be removed, I think the aim would be to just use this new behaviour going forward.PR Checklist
Developers certificate of origin
📚 Documentation preview 📚: https://mdanalysis--4330.org.readthedocs.build/en/4330/