Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add module_name variable #2

Merged
merged 8 commits into from
Sep 4, 2023
Merged

Add module_name variable #2

merged 8 commits into from
Sep 4, 2023

Conversation

lilyminium
Copy link
Member

Fixes #1

Probably need tests for griddata/formats too...

Copy link
Member

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah we can probably just do a ref to an old tag of griddataformats, that should work fine.

.github/workflows/ci.yaml Show resolved Hide resolved
action.yaml Outdated Show resolved Hide resolved
Copy link
Member

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Odd, not sure why CI isn't getting triggered.

@IAlibay
Copy link
Member

IAlibay commented Sep 4, 2023

O no it is.. invalid workflow file.

@IAlibay IAlibay closed this Sep 4, 2023
@IAlibay IAlibay reopened this Sep 4, 2023
@IAlibay
Copy link
Member

IAlibay commented Sep 4, 2023

Just undrafting to see if that's what is blocking the action.

@IAlibay IAlibay marked this pull request as ready for review September 4, 2023 19:26
@IAlibay IAlibay closed this Sep 4, 2023
@IAlibay IAlibay reopened this Sep 4, 2023
@IAlibay
Copy link
Member

IAlibay commented Sep 4, 2023

I've added a sparse checkout to try to get out of a bit of a cyclic issue, but it turns out it still won't trigger on PR.

I'm going to merge this in the hope that there's some indication as to what's going on.

@IAlibay IAlibay merged commit 1ce0fa2 into main Sep 4, 2023
@IAlibay IAlibay deleted the add-module-name branch September 4, 2023 20:05
@IAlibay
Copy link
Member

IAlibay commented Sep 4, 2023

Took a bit of work and a new token but it works now, thanks @lilyminium !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add separate input for pytest pyargs check vs package install name
2 participants