Add guild, alliance and guild list pages to the admin panel - #953
Draft
eduardosmaniotto wants to merge 15 commits into
Draft
eduardosmaniotto wants to merge 15 commits into
eduardosmaniotto wants to merge 15 commits into
Conversation
Adds three new admin panel pages backed by a new GuildService:
- /guilds: paginated, searchable list of all guilds, including logo,
member count, score and alliance.
- /guild/{id}: guild detail page with its members (name, account,
class, level, master level, position), ordered by rank.
- /alliance/{id}: lists all guilds belonging to an alliance, reachable
from either a member guild or the alliance master.
Guild data is read from the guild context; member enrichment with
character/account data (which lives in a separate player context) is
handled by a dedicated IGuildMemberEnricher so the two concerns don't
mix. Listing and search are pushed down to the persistence layer via
new IGuildServerContext methods (GetGuildsOrderedByNameAsync,
SearchGuildsAsync, GetAllianceMasterIdsAsync) instead of loading the
whole guild table into memory.
Also adds an 8x8 16-color GuildLogo component to render the game's
native guild logo bitmap format, and an AssistantMaster guild position
caption/resource that was missing from ModelResources.
Includes unit tests for GuildService (listing, search, pagination
fallback, member ordering, alliance resolution, enrichment) using the
in-memory persistence provider.
Implements the previously unhandled C1 E1 GuildRoleAssignRequest: only the guild master may promote/demote members to AssistantMaster, BattleMaster or NormalMember (no leadership transfer). The guild server now publishes position changes so members update without relog. Also fixes a NullReferenceException in GuildRelationshipChangeAction where failed validations crashed instead of returning the result, and sorts the guild list by rank (master, assistant, battle master, normal) then name.
Deterministic per-party badge colors (FNV-1a), short-lived IMemoryCache entries for the player-list copies, and a shared PartyDisplay helper with PartySize on the account interface. Add the guild column to all tabs (bulk-resolved, one lookup per distinct guild; failed lookups render as guild-less), localized badge titles and empty values, tab a11y attributes, and plugin-gated feature tabs so disabled stays distinguishable from enabled-but-idle.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds guild management visibility to the admin panel: a searchable guild list, a guild detail page with member roster, and an alliance page.
What's Included
/guilds— Paginated, searchable table of all guilds (name + logo, member count, score, alliance)./guild/{id}— Guild details: score, notice, alliance link, and the full member roster (character, account, class, level, master level, position)./alliance/{id}— All guilds belonging to an alliance, reachable from any member guild or from the alliance master itself.GuildLogocomponent — Renders the game's native 8×8, 16-color guild logo bitmap as an inline SVG.GuildService/IGuildService— Backed by new query methods onIGuildServerContext(GetGuildsOrderedByNameAsync,SearchGuildsAsync,GetAllianceMasterIdsAsync) so listing and search run as database queries rather than loading every guild into memory.IGuildMemberEnricher— Character/account enrichment of guild members is isolated behind this interface, since it depends on the player context rather than the guild context.AssistantMasterguild position caption toModelResources.GuildService(inMUnique.OpenMU.Web.Tests) using the in-memory persistence provider, plus a caption test forAssistantMaster.