Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch error for invalid URI. #2201

Merged
merged 3 commits into from
Dec 27, 2024
Merged

Catch error for invalid URI. #2201

merged 3 commits into from
Dec 27, 2024

Conversation

JPBergsma
Copy link
Contributor

@JPBergsma JPBergsma commented Dec 18, 2024

This is a second attempt to resolve issue #2197 and should enable connecting to a MongoDB Atlas Cluster via its connection string.

This is a second attempt to resolve issue#2197 and should enable connecting to a MongoDB Atlas Cluster via its connection string.
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 90.66%. Comparing base (7798f67) to head (196a827).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
optimade/server/config.py 50.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2201      +/-   ##
==========================================
- Coverage   90.69%   90.66%   -0.04%     
==========================================
  Files          75       75              
  Lines        4858     4861       +3     
==========================================
+ Hits         4406     4407       +1     
- Misses        452      454       +2     
Flag Coverage Δ
project 90.66% <50.00%> (-0.04%) ⬇️
validator 90.66% <50.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JPBergsma JPBergsma merged commit 2035851 into main Dec 27, 2024
12 of 13 checks passed
@JPBergsma JPBergsma deleted the JPBergsma-patch-2 branch December 27, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant