forked from phil-mitchell/knex
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
d67e604
commit 8634a41
Showing
2 changed files
with
14 additions
and
15 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8634a41
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With regard to the changes on these lines, I realized you could call the
exec
function without a callback after looking at the code snippet here, wrapping the callback in a promise is known to cause issues on older versions (sqlanywhere/node-sqlanywhere#32), but it was not apparent that newer versions also had this issue until I made this change.The other changes just fix whitespace, define a method which seemed to be missing and... I forgot to revert my change on this line from when I had a debug logger...
8634a41
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change on this line was reverted by commit c33832c