Initial attempt to enable JWT auth to look at a configurable header i… #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nstead of `Authorization`
mgratzer
reviewed
Oct 19, 2023
pkg/middleware/jwt_session.go
Outdated
| @@ -60,7 +62,11 @@ func (j *jwtSessionLoader) loadSession(next http.Handler) http.Handler { | |||
| // getJwtSession loads a session based on a JWT token in the authorization header. | |||
| // (see the config options skip-jwt-bearer-tokens and extra-jwt-issuers) | |||
| func (j *jwtSessionLoader) getJwtSession(req *http.Request) (*sessionsapi.SessionState, error) { | |||
| auth := req.Header.Get("Authorization") | |||
| authHeader := "Authorization" | |||
| if j.jwtAuthHeader == "" { | |||
There was a problem hiding this comment.
Do we ever use the header from the config in this code (:warning: I have no Go knowledge whatsoever…)
I would assume something like this instead.
authHeader := "Authorization"
if j.jwtAuthHeader != nil && len(strings.TrimSpace(j.jwtAuthHeader)) > 0 {
authHeader = j.jwtAuthHeader
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nstead of
AuthorizationDescription
Motivation and Context
How Has This Been Tested?
Checklist: