chore: add full CR example #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
rollandf
commented
Oct 22, 2024
rollandf
commented
- Add full NCP example
- Specify full container image in platform page
- Update versions to 24.10 beta4
|
|
|
|
| NicClusterPolicy Custom Resource Example | ||
| **************************************** | ||
|
|
||
| The following NIC Cluster Policy example contains all the sub-components that NVIDA Network Operator can deploy. |
There was a problem hiding this comment.
just to be extra clear, can you add something in the lines of:
"This example should serve as reference, it is not recommended to apply it as is to your cluster."
| CRDs <crds.rst> | ||
| NicClusterPolicy example <cr-full-example.rst> |
There was a problem hiding this comment.
"NicClusterPolicy reference example" ?
that said, im fine with what there currently is.
|
minor comments otherwise lgtm |
- Add full NCP example - Specify full container image in platform page - Update versions to 24.10 beta4 Signed-off-by: Fred Rolland <[email protected]>
rollandf
force-pushed
the
container-images
branch
from
c8f919e to
a1333ef
Compare
adrianchiris
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.