-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove helm NicClusterPolicy install from docs #67
Remove helm NicClusterPolicy install from docs #67
Conversation
858a708
to
2650643
Compare
Signed-off-by: killianmuldoon <[email protected]>
2650643
to
d8aa53c
Compare
deploy: false | ||
Note: You may need to change the interface names in the NicClusterPolicy to those used by your target nodes. | ||
|
||
.. parsed-literal:: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.. parsed-literal:: | |
.. code-block:: yaml |
shouldn't this be rather a yaml
code block? And all other occurrences
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately no - as we need to substitute the version numbers here. That functionality doesn't work with code-block. So here we're trading off the variable substitution for syntax highlighting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, wasn't aware of that. Thanks
@rollandf @adrianchiris please add me as reviewer for upcoming doc changes. here few comments we should get address in upcoming changed:
|
@noama-nv please star the project to get notifications. you can then get notified on changes. |
@adrianchiris i am, but in this case it was reviewed and merge at the speed of light :) |
Remove the instructions for installing the NicClusterPolicy through helm from the documentation and replace it with a two step process that involves applying the NicClusterPolicy directly using
kubectl
.This feature is deprecated and is going to be removed from the Network Operator helm chart in a future release