Skip to content

Commit

Permalink
cherry-pick: Correct theme value for Snap UI footer buttons (#29495)
Browse files Browse the repository at this point in the history
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

Cherry-pick
1fbb63c
to the RC.

The Snap UI footer buttons use the DS button which forces light theme,
this does not work for the colors used in the Snap buttons, therefore we
revert back to using the actually selected theme.

[![Open in GitHub

Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/29434?quickstart=1)
  • Loading branch information
FrederikBolding authored Jan 8, 2025
1 parent 136b5a8 commit 7a4fa94
Showing 1 changed file with 1 addition and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ export const SnapUIFooterButton: FunctionComponent<
alignItems: AlignItems.center,
flexDirection: FlexDirection.Row,
}}
data-theme={null}
>
{isSnapAction && !hideSnapBranding && (
<SnapIcon snapId={snapId} avatarSize={IconSize.Sm} marginRight={2} />
Expand Down

0 comments on commit 7a4fa94

Please sign in to comment.