-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(test): remove polyfill-crypto.getrandomvalues #23145
chore(test): remove polyfill-crypto.getrandomvalues #23145
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Removed dependencies detected. Learn more about Socket for GitHub ↗︎ 🚮 Removed packages: npm/[email protected] |
98d8454
to
4f8813b
Compare
8ff1ff7
to
e6c8420
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #23145 +/- ##
===========================================
+ Coverage 67.32% 67.34% +0.03%
===========================================
Files 1276 1282 +6
Lines 49739 50065 +326
Branches 12925 12985 +60
===========================================
+ Hits 33482 33715 +233
- Misses 16257 16350 +93 ☔ View full report in Codecov by Sentry. |
00c1660
to
c2fbe3c
Compare
189dddd
to
4140aa7
Compare
2c032ff
to
9e36cb9
Compare
18dde1d
to
6d7b42f
Compare
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
new author ok |
e96fb13
to
69230bb
Compare
69230bb
to
9f04070
Compare
No release label on PR. Adding release label release-11.17.0 on PR, as PR was added to branch 11.17.0 when release was cut. |
Description
Use of
polyfill-crypto.getrandomvalues
is no longer required nor recommended. This removes it.Related issues
Manual testing steps
Screenshots/Recordings
Before
N/A
After
N/A
Pre-merge author checklist
Pre-merge reviewer checklist