Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(test): remove polyfill-crypto.getrandomvalues #23145

Merged
merged 1 commit into from
May 5, 2024

Conversation

legobeat
Copy link
Contributor

Description

Use of polyfill-crypto.getrandomvalues is no longer required nor recommended. This removes it.

Related issues

Manual testing steps

Screenshots/Recordings

Before

N/A

After

N/A

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

socket-security bot commented Feb 23, 2024

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: npm/[email protected]

View full report↗︎

@legobeat legobeat force-pushed the deps-crypto-getrandomvalues branch from 98d8454 to 4f8813b Compare February 23, 2024 06:25
@legobeat legobeat added dependencies Pull requests that update a dependency file team-security labels Feb 23, 2024
@legobeat legobeat marked this pull request as ready for review February 23, 2024 06:42
@legobeat legobeat requested a review from a team as a code owner February 23, 2024 06:42
@legobeat legobeat force-pushed the deps-crypto-getrandomvalues branch 5 times, most recently from 8ff1ff7 to e6c8420 Compare February 28, 2024 00:59
Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.34%. Comparing base (945750d) to head (9f04070).
Report is 20 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #23145      +/-   ##
===========================================
+ Coverage    67.32%   67.34%   +0.03%     
===========================================
  Files         1276     1282       +6     
  Lines        49739    50065     +326     
  Branches     12925    12985      +60     
===========================================
+ Hits         33482    33715     +233     
- Misses       16257    16350      +93     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@legobeat legobeat force-pushed the deps-crypto-getrandomvalues branch 6 times, most recently from 00c1660 to c2fbe3c Compare March 6, 2024 22:48
@legobeat legobeat force-pushed the deps-crypto-getrandomvalues branch 11 times, most recently from 189dddd to 4140aa7 Compare March 14, 2024 22:23
@legobeat legobeat force-pushed the deps-crypto-getrandomvalues branch 2 times, most recently from 2c032ff to 9e36cb9 Compare May 1, 2024 09:53
@legobeat legobeat force-pushed the deps-crypto-getrandomvalues branch 2 times, most recently from 18dde1d to 6d7b42f Compare May 2, 2024 11:13
Copy link

socket-security bot commented May 2, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

@legobeat
Copy link
Contributor Author

legobeat commented May 2, 2024

@SocketSecurity ignore npm/@storybook/[email protected]

new author ok

@legobeat legobeat force-pushed the deps-crypto-getrandomvalues branch 16 times, most recently from e96fb13 to 69230bb Compare May 5, 2024 03:07
@legobeat legobeat force-pushed the deps-crypto-getrandomvalues branch from 69230bb to 9f04070 Compare May 5, 2024 03:29
@legobeat legobeat merged commit f54730b into MetaMask:develop May 5, 2024
72 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 5, 2024
@metamaskbot
Copy link
Collaborator

No release label on PR. Adding release label release-11.17.0 on PR, as PR was added to branch 11.17.0 when release was cut.

@gauthierpetetin gauthierpetetin added the release-12.0.0 Issue or pull request that will be included in release 12.0.0 label Jun 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file release-12.0.0 Issue or pull request that will be included in release 12.0.0 team-security
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants