-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Enable single test execution across multiple browsers #23357
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
A few comments:
|
Thanks @HowardBraham, I have addressed your comments. |
141797d
to
5b1bc8e
Compare
Sorry, noticed three more things:
|
Builds ready [5b1bc8e]
Page Load Metrics (951 ± 411 ms)
Bundle size diffs
|
Not sure if it's the best approach, but could we set the default parameter to "all"? This way, if a user runs an e2e test without specifying a browser, it would automatically execute the tests on both browsers, similar to when we explicitly pass "all" as the parameter. |
…aMask/metamask-extension into test/run-single-test-across-browsers
… test/run-single-test-across-browsers
… test/run-single-test-across-browsers
Builds ready [7672e5f]
Page Load Metrics (787 ± 451 ms)
Bundle size diffs
|
Builds ready [0303490]
Page Load Metrics (512 ± 407 ms)
Bundle size diffs
|
Builds ready [7400843]
Page Load Metrics (1159 ± 519 ms)
Bundle size diffs
|
Builds ready [23a9eb9]
Page Load Metrics (1004 ± 599 ms)
Bundle size diffs
|
nice addition. LGTM |
Builds ready [218f6fd]
Page Load Metrics (962 ± 514 ms)
Bundle size diffs
|
Builds ready [17eb408]
Page Load Metrics (914 ± 531 ms)
Bundle size diffs
|
Description
This PR is to execute single test across multiple browsers(chrome and firefox) locally.
E2E debug is now true by default
Updated ReadMe for the specific changes
Note:- I attempted to convert this to a TypeScript file but was unsuccessful, also it's used internally and hence it should be fine.
Manual testing steps
Run the test in codespace or locally --> Checkout to the branch
yarn install
yarn build:test
yarn test:e2e:single test/e2e/tests/network/update-network.spec.ts --browser=all --debug --leave-running
Without the browser
yarn test:e2e:single test/e2e/tests/network/update-network.spec.ts
Pre-merge author checklist
Pre-merge reviewer checklist