refactor: change CurrencyRateController Polling to be UI driven

[jiexi]

Description

Currently currency rate polling is started and stopped based on active trusted connections to the MetaMaskController (i.e. whenever the wallet ui is opened). In the future we want polling to be tied to the actual components that rely on polled currency rate state. As a transitionary step, this PR moves currency rate polling from MetaMaskController into a hook that wraps the root level <Routes> component. Nothing changes except that currency rate polling goes from being MetaMaskController connection driven to actually wallet UI driven. Polling will still occur as long at least one wallet UI is open as it currently already does.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2083

Manual testing steps

1. Open background console - network tab
2. Filter by min-api.cryptocompare.com
3. Open wallet UI
4. See request in background network tab
5. Change network
6. See new request
7. Close wallet UI
8. Open wallet UI right away
9. See no new requests
10. Close wallet UI
11. Wait 3 minutes
12. See no new requests
13. Open wallet UI
14. See new request
15. Leave wallet UI open
16. Wait 3 minutes
17. See new request

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've clearly explained what problem this PR is solving and how it is solved.
• I've linked related issues
• I've included manual testing steps
• I've included screenshots/recordings if applicable
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
• I’ve properly set the pull request status:
  • In case it's not yet "ready for review", I've set it to "draft".
  • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[codecov]

Codecov Report

Attention: Patch coverage is 10.71429% with 25 lines in your changes are missing coverage. Please review.

Project coverage is 67.46%. Comparing base (ec03702) to head (17af907).

Files	Patch %	Lines
ui/store/actions.ts	18.18%	9 Missing ⚠️
ui/hooks/useCurrencyRatePolling.ts	0.00%	7 Missing ⚠️
app/scripts/metamask-controller.js	0.00%	4 Missing ⚠️
ui/contexts/currencyRate.js	0.00%	4 Missing ⚠️
ui/hooks/usePolling.ts	50.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #23476      +/-   ##
===========================================
- Coverage    67.53%   67.46%   -0.06%     
===========================================
  Files         1261     1263       +2     
  Lines        49289    49327      +38     
  Branches     12856    12854       -2     
===========================================
- Hits         33283    33278       -5     
- Misses       16006    16049      +43     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[metamaskbot]

Builds ready [0c8eefb]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5
  • common: 0, 1, 2, 3, 4, 5, 6
  • content-script: 0
  • contentscript: contentscript
  • disable-console: disable-console
  • policy-load: policy-load
  • sentry-install: sentry-install
  • ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1029 ± 420 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	73	258	127	44	21
		domContentLoaded	10	83	25	17	8
		load	60	2429	1029	874	420
		domInteractive	10	83	25	17	8

Bundle size diffs [🚀 Bundle size reduced!]

• background: -619 Bytes (-0.02%)
• ui: 2.43 KiB (0.03%)
• common: 0 Bytes (0.00%)

[metamaskbot]

Builds ready [ad1c711]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8
  • content-script: 0
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1272 ± 574 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	61	403	171	109	52
		domContentLoaded	10	73	27	17	8
		load	50	2735	1272	1195	574
		domInteractive	10	73	27	17	8

Bundle size diffs [🚀 Bundle size reduced!]

• background: -445 Bytes (-0.01%)
• ui: 2.14 KiB (0.03%)
• common: 331 Bytes (0.01%)

[adonesky1]

LGTM!

[metamaskbot]

Builds ready [23b4931]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8
  • content-script: 0
  • ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1136 ± 627 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	71	151	101	24	12
		domContentLoaded	10	34	19	7	3
		load	62	3069	1136	1305	627
		domInteractive	10	34	19	7	3

Bundle size diffs [🚀 Bundle size reduced!]

• background: -389 Bytes (-0.01%)
• ui: 2.14 KiB (0.03%)
• common: 331 Bytes (0.01%)

[legobeat]

In the future we want polling to be tied to the actual components that rely on polled currency rate state

Is this actually desired? By making the HTTP request timing depend on user action, user activity metadata leaking to price provider (and middle-parties) will increase.

Tangential but related: Why are we not fetching currency rates like ETH-USD via on-chain oracles instead (or in addition)? This would enable price lookups without any third-party connections, only relying on eth_call to oracle(s). Could be worth looking into as an alternative or parallel path to reduce non-chain API calls as part of this feature.

[adonesky1]

Is this actually desired? By making the HTTP request timing depend on user action, user activity metadata leaking to price provider (and middle-parties) will increase.

not sure I follow? Are you saying that the metadata associated with http requests of when users have certain UI's open is a leak? If so I don't think thats really a reasonable boundary to set out for ourself, it a pretty common pattern for how to determine when or when not to make queries... but perhaps I'm misunderstanding. The goal here is to only query for what we need based on what actual data needs to be rendered and minimize any additional polling we're doing outside of that.

Why are we not fetching currency rates like ETH-USD via on-chain oracles instead (or in addition)?

Definitely worth considering but very much out of scope for this particular PR. I would raise this with @alfeng6 and the assets team!

[metamaskbot]

Builds ready [17af907]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8
  • content-script: 0
  • ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1789 ± 664 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	83	238	154	49	23
		domContentLoaded	13	117	44	33	16
		load	69	3609	1789	1382	664
		domInteractive	13	117	44	33	16

Bundle size diffs [🚀 Bundle size reduced!]

• background: -389 Bytes (-0.01%)
• ui: 2.14 KiB (0.03%)
• common: 331 Bytes (0.01%)