Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #23304 - Only use Confusable during send with ENS #23582

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

darkwing
Copy link
Contributor

@darkwing darkwing commented Mar 19, 2024

Description*

We should only be using Confusable for AddressListItem when the user is entering an unknown address during the send flow or adding a contact.

Open in GitHub Codespaces

Related issues

Fixes: #23304

Manual testing steps

  1. Open the new send flow
  2. Type metamask.eth
  3. See red 'm's, noting that they could be a rn
  4. Type vitalik.eth
  5. See no red characters since there are no confusable letter combinations there
  6. Look at your contact list
  7. Any contact with an m should not have red text

Screenshots/Recordings

Before

Available in issue

After

SCR-20240319-kcss SCR-20240319-kcpv SCR-20240319-kdao

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@darkwing darkwing requested a review from a team as a code owner March 19, 2024 16:07
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Mar 19, 2024
@darkwing darkwing added team-wallet-ux needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. and removed INVALID-PR-TEMPLATE PR's body doesn't match template labels Mar 19, 2024
@darkwing darkwing requested a review from a team as a code owner March 19, 2024 16:34
@darkwing darkwing force-pushed the release-send-fix-confusable branch from a1d0734 to e932569 Compare March 21, 2024 13:59
@hesterbruikman hesterbruikman added the amon-hen-v1 Represents blocking issues for the release of Amon Hen label Mar 21, 2024
@darkwing darkwing force-pushed the release-send-fix-confusable branch from d2d619c to 65fbf8e Compare March 22, 2024 22:22
@darkwing darkwing merged commit 67475ea into release-send Mar 22, 2024
35 of 44 checks passed
@darkwing darkwing deleted the release-send-fix-confusable branch March 22, 2024 22:36
@github-actions github-actions bot locked and limited conversation to collaborators Mar 22, 2024
@darkwing darkwing restored the release-send-fix-confusable branch April 19, 2024 19:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
amon-hen-v1 Represents blocking issues for the release of Amon Hen needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. team-wallet-ux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants