-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Prevent trackEvent being called multiple times for #23633
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #23633 +/- ##
========================================
Coverage 68.53% 68.53%
========================================
Files 1154 1154
Lines 44026 44026
Branches 11789 11789
========================================
Hits 30170 30170
Misses 13856 13856 ☔ View full report in Codecov by Sentry. |
Trying to validate it locally, and encountered multiple metric sent whenever open the popup, can you validate that this is correct behavior? empty-banner-event.mov |
#23633 (comment) LGTM ! |
oooo nice find |
Missing release label release-11.14.0 on PR. Adding release label release-11.14.0 on PR and removing other release labels(release-11.14.1), as PR was added to branch 11.14.0 when release was cut. |
Description
The
trackEvent
calls forEmptyBuyBannerDisplayed
andEmptyReceiveBannerDisplayed
are being called far too many times on the home screen. This PR ensures the event is tracked only once per tab render.Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2265
Manual testing steps
ui/components/app/asset-list/asset-list.js
's useEffect to ensure the event is only tracked once.Screenshots/Recordings
Before
N/A
After
N/A
Pre-merge author checklist
Pre-merge reviewer checklist