Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update @metamask/safe-event-emitter to v3.1.1 #23665

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

davidmurdoch
Copy link
Contributor

@davidmurdoch davidmurdoch commented Mar 23, 2024

The breaking change from v2 to v3 was dropping Node v12 support.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [fd0e1a8]
Page Load Metrics (1022 ± 549 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint834911569746
domContentLoaded169732199
load69274410221143549
domInteractive169732199
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 3.93 KiB (0.11%)
  • ui: 9 Bytes (0.00%)
  • common: 18 Bytes (0.00%)

The breaking change from v2 to v3 was dropping Node v12 support.
@davidmurdoch davidmurdoch force-pushed the update-safe-event-emitter branch from fd0e1a8 to 737a402 Compare March 23, 2024 19:30
@metamaskbot
Copy link
Collaborator

Builds ready [737a402]
Page Load Metrics (715 ± 451 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint733951437234
domContentLoaded1088342211
load602430715939451
domInteractive1088342211
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -2.47 KiB (-0.07%)
  • ui: -1.15 KiB (-0.02%)
  • common: -4.74 KiB (-0.09%)

@davidmurdoch davidmurdoch marked this pull request as ready for review March 23, 2024 20:32
@davidmurdoch davidmurdoch requested review from a team as code owners March 23, 2024 20:32
@DDDDDanica DDDDDanica merged commit d03a6a0 into develop Mar 25, 2024
65 of 66 checks passed
@DDDDDanica DDDDDanica deleted the update-safe-event-emitter branch March 25, 2024 19:02
@github-actions github-actions bot locked and limited conversation to collaborators Mar 25, 2024
@metamaskbot metamaskbot added release-11.14.1 Issue or pull request that will be included in release 11.14.1 release-11.14.0 Issue or pull request that will be included in release 11.14.0 and removed release-11.14.1 Issue or pull request that will be included in release 11.14.1 labels Mar 25, 2024
@metamaskbot
Copy link
Collaborator

Missing release label release-11.14.0 on PR. Adding release label release-11.14.0 on PR and removing other release labels(release-11.14.1), as PR was added to branch 11.14.0 when release was cut.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.14.0 Issue or pull request that will be included in release 11.14.0 team-extension-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants