Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove extraneous charset attribute from script tags in all utf-8 HTML5 documents #23675

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

davidmurdoch
Copy link
Contributor

@davidmurdoch davidmurdoch commented Mar 24, 2024

The html spec living standard says:

Authors should not specify a charset attribute on a script element.

from https://html.spec.whatwg.org/dev/obsolete.html#obsolete-but-conforming-features

> Authors should not specify a charset attribute on a script element.

from https://html.spec.whatwg.org/dev/obsolete.html
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@davidmurdoch davidmurdoch changed the title refactor: remove extraneous charset attribute from script tags in all utf-8 HTML5 documents refactor: remove extraneous charset attribute from script tags in all utf-8 HTML5 documents Mar 24, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [3dcaf62]
Page Load Metrics (936 ± 504 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint674161447938
domContentLoaded106527178
load5026219361049504
domInteractive106527178
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@davidmurdoch davidmurdoch marked this pull request as ready for review March 24, 2024 19:09
@davidmurdoch davidmurdoch requested review from kumavis and a team as code owners March 24, 2024 19:09
@davidmurdoch davidmurdoch merged commit 35ae827 into develop Mar 27, 2024
73 of 74 checks passed
@davidmurdoch davidmurdoch deleted the refactor-charset branch March 27, 2024 22:03
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2024
@metamaskbot metamaskbot added the release-11.15.0 Issue or pull request that will be included in release 11.15.0 label Mar 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.15.0 Issue or pull request that will be included in release 11.15.0 team-extension-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants