Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixes in NFT listing label and values #29046

Merged
merged 14 commits into from
Jan 8, 2025
Merged

fix: Fixes in NFT listing label and values #29046

merged 14 commits into from
Jan 8, 2025

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Dec 10, 2024

Description

Fixes in NFT listing:

  1. Fix order of listing state changes
  2. Change label from You receive to Listing price
  3. Show received value in gray background

Related issues

Fixes: #28977

Manual testing steps

  1. Submit NFT listing confirmation
  2. Check the confirmations page
  3. Ensure that order of state changes is correct and label is also correct

Screenshots/Recordings

Screenshot 2024-12-10 at 4 03 42 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added the team-confirmations Push issues to confirmations team label Dec 10, 2024
@jpuri jpuri requested a review from a team as a code owner December 10, 2024 10:54
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Base automatically changed from sign_decoding_label_fix to main December 12, 2024 13:45
@jpuri jpuri enabled auto-merge December 13, 2024 09:50
@metamaskbot
Copy link
Collaborator

Builds ready [abcba6d]
Page Load Metrics (1807 ± 91 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint24320611646471226
domContentLoaded14232119177819694
load14822125180719091
domInteractive257440168
backgroundConnect979322110
firstReactRender1785362411
getState670232411
initialActions01000
loadScripts10401541129616780
setupStore76614157
uiStartup168925542112236113
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 738 Bytes (0.01%)
  • common: 61 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [ff7b9bd]
Page Load Metrics (1751 ± 57 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15261925174511957
domContentLoaded15021906171212460
load15181933175111957
domInteractive25257676732
backgroundConnect10110412613
firstReactRender1593322311
getState587182110
initialActions01000
loadScripts10751440127110751
setupStore66018189
uiStartup16852538200419091
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 738 Bytes (0.01%)
  • common: 61 Bytes (0.00%)

return undefined;
};

const stateChangeOrder = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor, capitals and underscores and top of file as constant?

@jpuri jpuri added this pull request to the merge queue Jan 7, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 7, 2025
@jpuri jpuri added this pull request to the merge queue Jan 8, 2025
Merged via the queue into main with commit 8d9fa1a Jan 8, 2025
77 checks passed
@jpuri jpuri deleted the nft_listing_fixes branch January 8, 2025 06:39
@github-actions github-actions bot locked and limited conversation to collaborators Jan 8, 2025
@metamaskbot metamaskbot added the release-12.11.0 Issue or pull request that will be included in release 12.11.0 label Jan 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.11.0 Issue or pull request that will be included in release 12.11.0 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Some signature decoding don't match designs
4 participants