fix: show localized snap name in snap tag

[montelaidev]

Description

This PR fixes the issue where the localized snap name is not being used when in the account tag. It also removes tech debt which is the mergeAccount function that isn't needed any more.

Related issues

Fixes: https://github.com/MetaMask/accounts-planning/issues/769

Manual testing steps

1. Install the BTC snap
2. Create a BTC account
3. Click on the account menu and see that the name is correct.

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [37ed0cb]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6
  • common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 12, 13, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1935 ± 66 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1712	2273	1937	134	64
		domContentLoaded	1699	2208	1902	130	63
		load	1713	2280	1935	138	66
		domInteractive	24	99	43	18	9
		backgroundConnect	8	82	33	23	11
		firstReactRender	14	95	22	17	8
		getState	87	385	146	69	33
		initialActions	0	1	0	0	0
		loadScripts	1330	1749	1492	110	53
		setupStore	6	76	12	15	7
		uiStartup	1927	2842	2273	232	111

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: -1.76 KiB (-0.02%)
• common: 0 Bytes (0.00%)

[metamaskbot]

Builds ready [4d6a2f3]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6
  • common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 12, 13, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1791 ± 77 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	231	2192	1741	385	185
		domContentLoaded	1498	2077	1750	145	70
		load	1506	2135	1791	160	77
		domInteractive	25	103	41	17	8
		backgroundConnect	6	118	48	32	16
		firstReactRender	17	179	57	42	20
		getState	5	182	35	43	21
		initialActions	0	1	0	0	0
		loadScripts	1128	1592	1317	107	51
		setupStore	6	87	21	24	12
		uiStartup	1713	2745	2139	312	150

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: -1.76 KiB (-0.02%)
• common: 0 Bytes (0.00%)

[metamaskbot]

Builds ready [555f288]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7
  • common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 12, 13, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1843 ± 96 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	243	2305	1756	400	192
		domContentLoaded	1573	2243	1817	193	93
		load	1594	2311	1843	199	96
		domInteractive	26	214	65	45	22
		backgroundConnect	8	68	28	20	9
		firstReactRender	16	94	52	30	14
		getState	6	81	22	24	12
		initialActions	0	1	0	0	0
		loadScripts	1153	1755	1350	160	77
		setupStore	6	59	17	17	8
		uiStartup	1746	2790	2154	274	132

[vinnyhoward]

LGTM