Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: merge queue metrics - test the number increases when PR is kicked out #29123

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

seaona
Copy link
Contributor

@seaona seaona commented Dec 12, 2024

Description

This PR is intended for testing the merge queue metrics work done by @itsyoboieltr .
The way this will work is:

  1. This test currently passes. It's making a live request to a site we control
  2. We get approvals for the PR
  3. We put it into the merge queue
  4. We change the live site so the test fail
  5. The test fails and the PR is kicked out

See metrics:

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@seaona seaona requested a review from a team as a code owner December 12, 2024 08:23
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@seaona seaona changed the title test: merge queue metrics - this PR won't get merged, as we'll make it fail once it's in the merge queue test: merge queue metrics - test the number increases when PR is kicked out Dec 12, 2024
danjm
danjm previously approved these changes Dec 12, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [27f0e5c]
Page Load Metrics (1689 ± 55 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15011906169111053
domContentLoaded14951895167311053
load15011904168911555
domInteractive278249178
backgroundConnect85621147
firstReactRender1676402512
getState55318178
initialActions01000
loadScripts10851441125510350
setupStore67315199
uiStartup17492094192910651
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

chloeYue
chloeYue previously approved these changes Dec 12, 2024
@seaona seaona added this pull request to the merge queue Dec 12, 2024
@seaona seaona removed this pull request from the merge queue due to a manual request Dec 12, 2024
@seaona seaona dismissed stale reviews from chloeYue and danjm via d0cdea8 December 12, 2024 10:06
@seaona seaona requested review from chloeYue and danjm December 12, 2024 11:02
chloeYue
chloeYue previously approved these changes Dec 12, 2024
danjm
danjm previously approved these changes Dec 12, 2024
chloeYue
chloeYue previously approved these changes Dec 12, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [131bebb]
Page Load Metrics (1591 ± 84 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint14112253160017282
domContentLoaded14042225157017082
load14122254159117484
domInteractive239939199
backgroundConnect865252010
firstReactRender1596322612
getState55416188
initialActions01000
loadScripts10571801118615976
setupStore6559115
uiStartup16052460180418187
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@seaona seaona added this pull request to the merge queue Dec 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 12, 2024
@seaona seaona added the DO-NOT-MERGE Pull requests that should not be merged label Dec 12, 2024
@itsyoboieltr
Copy link
Contributor

This test passed successfully. Thank you @seaona !

@github-actions github-actions bot locked and limited conversation to collaborators Jan 8, 2025
@itsyoboieltr itsyoboieltr reopened this Jan 8, 2025
@itsyoboieltr
Copy link
Contributor

We need to test again, because I pushed a new fix for the other test case, I am not sure if it broke this one or not: MetaMask/github-tools#33

@itsyoboieltr itsyoboieltr dismissed stale reviews from chloeYue and danjm via b0ec7d4 January 8, 2025 20:35
@seaona seaona removed the DO-NOT-MERGE Pull requests that should not be merged label Jan 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants