-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: merge queue metrics - test the number increases when PR is kicked out #29123
Open
seaona
wants to merge
8
commits into
main
Choose a base branch
from
test-merge-queues
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+28
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
seaona
changed the title
test: merge queue metrics - this PR won't get merged, as we'll make it fail once it's in the merge queue
test: merge queue metrics - test the number increases when PR is kicked out
Dec 12, 2024
danjm
previously approved these changes
Dec 12, 2024
Builds ready [27f0e5c]
Page Load Metrics (1689 ± 55 ms)
Bundle size diffs
|
chloeYue
previously approved these changes
Dec 12, 2024
chloeYue
previously approved these changes
Dec 12, 2024
danjm
previously approved these changes
Dec 12, 2024
chloeYue
previously approved these changes
Dec 12, 2024
Builds ready [131bebb]
Page Load Metrics (1591 ± 84 ms)
Bundle size diffs
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Dec 12, 2024
This test passed successfully. Thank you @seaona ! |
We need to test again, because I pushed a new fix for the other test case, I am not sure if it broke this one or not: MetaMask/github-tools#33 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is intended for testing the merge queue metrics work done by @itsyoboieltr .
The way this will work is:
See metrics:
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist