feat: add `scopes` field to `KeyringAccount` #29195

ccharly · 2024-12-13T11:22:54Z

Description

Testing the new scopes added on the KeyringAccount.

Related issues

Requires this PR to be merged first:

refactor: use new @metamask/keyring-api layout (split packages) #28861

Related to:

Manual testing steps

N/A

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-12-13T11:23:08Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

socket-security · 2024-12-13T11:24:09Z

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@metamask/[email protected]	network	`0`	1.48 MB	metamaskbot
npm/@metamask/[email protected]	None	`+1`	344 kB	metamaskbot
npm/@metamask/[email protected]	None	`0`	484 kB	metamaskbot
npm/@metamask/[email protected]	None	`0`	63 kB	metamaskbot
npm/@metamask/[email protected]	None	`0`	31.4 kB	metamaskbot
npm/@metamask/[email protected]	None	`0`	58.8 kB	metamaskbot
npm/@metamask/[email protected]	network	`0`	995 kB	metamaskbot
npm/@scure/[email protected]	None	`0`	122 kB	paulmillr
npm/[email protected]	None	`0`	13.3 kB	sheetjs
npm/[email protected]	None	`0`	5 kB	sheetjs
npm/[email protected]	None	`0`	113 kB	sheetjs

🚮 Removed packages: npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@scure/[email protected], npm/[email protected]

View full report↗︎

ccharly · 2025-01-07T09:38:57Z

@metamaskbot update-policies

metamaskbot · 2025-01-07T09:51:40Z

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

This reverts commit 370f06e.

socket-security · 2025-01-08T21:32:47Z

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/@metamask/[email protected], npm/@metamask/[email protected]

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

## Explanation Testing the new `scopes` field for `KeyringAccount` ## References - MetaMask/accounts#101 - MetaMask/metamask-extension#29195 ## Changelog ### `@metamask/accounts-controller` - **CHANGED**: Bump `keyring-api` to `^13.0.0` - **CHANGED**: Bump `keyring-internal-api` to `^1.1.0` - **CHANGED**: **BREAKING:** Add new `scopes` field to `InternalAccount` - This new field wil automatically defaults to `eip155` (CAIP-2 chain ID namespace for EVM) for newly created EOA accounts (both Snap and "normal" accounts). ### `@metamask/assets-controllers` - **CHANGED**: Bump `keyring-internal-api` to `^1.1.0` ### `@metamask/chain-controller` - **CHANGED**: Bump `keyring-internal-api` to `^1.1.0` ### `@metamask/keyring-controller` - **CHANGED**: Bump `keyring-api` to `^13.0.0` - **CHANGED**: Bump `keyring-internal-api` to `^1.1.0` - **CHANGED**: Await for `generateRandomMnemonic` keyring calls - Not all keyrings uses an `async` implementation for this method, but `await`ing should cover both (synchronous and asynchronous) cases. - This change is required since the bump of `@metamask/utils@^11.0.1` that changed the `generateRandomMnemonic` function signature for the `EthKeyring` interface (coming from `@metamask/keyring-internal-api`. ### `@metamask/profile-sync-controller` - **CHANGED**: Bump `keyring-api` to `^13.0.0` - **CHANGED**: Bump `keyring-internal-api` to `^1.1.0` ## Checklist - [ ] I've updated the test suite for new or updated code as appropriate - [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [ ] I've highlighted breaking changes using the "BREAKING" category above as appropriate - [ ] I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

ccharly · 2025-01-09T15:30:14Z

@metamaskbot update-policies

metamaskbot · 2025-01-09T15:42:54Z

No policy changes

ccharly · 2025-01-09T16:47:00Z

@SocketSecurity ignore npm/@metamask/[email protected]
@SocketSecurity ignore npm/@metamask/[email protected]

Those are our Snaps.

metamaskbot · 2025-01-09T17:06:23Z

Builds ready [400d2d3]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 13, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1704 ± 94 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	347	2119	1618	338	162
		domContentLoaded	1432	2110	1684	199	95
		load	1487	2123	1704	195	94
		domInteractive	24	396	85	107	51
		backgroundConnect	9	64	20	13	6
		firstReactRender	16	100	45	28	13
		getState	5	59	16	18	9
		initialActions	0	1	0	0	0
		loadScripts	1050	1636	1267	170	82
		setupStore	6	68	13	16	8
		uiStartup	1668	2431	1958	242	116

ccharly and others added 21 commits December 3, 2024 17:00

refactor: use new accounts packages

f6d5942

chore: lavamoat:auto

cbd9f36

chore: yarn dedupe

bf4405f

chore: update resolutions

de54690

Merge branch 'main' into refactor/use-new-accounts-packages

356eab7

chore: update resolutions

0584a61

Merge branch 'main' into refactor/use-new-accounts-packages

0fb1493

chore: dedupe + lavamoat:auto

a2b7d0b

chore: update deps

a39c3df

chore: lint

6dce397

chore: update deps

238f522

chore: remove preview builds

ab65f1f

Merge branch 'main' into refactor/use-new-accounts-packages

7cf8701

chore: dedupe

dfa88e1

Merge branch 'main' into refactor/use-new-accounts-packages

9584e9e

Merge branch 'main' into refactor/use-new-accounts-packages

dc10d94

chore: lavamoat:auto

5ea8323

chore: dedupe

45784bb

Merge branch 'main' into refactor/use-new-accounts-packages

50035f3

Merge branch 'main' into refactor/use-new-accounts-packages

384c9e9

ci: add flags.circleci.timeoutMinutes

281c5bf

metamaskbot added the team-accounts label Dec 13, 2024

feat: use new scopes from KeyringAccount

5a28bd5

ccharly force-pushed the feat/keyring-account-scopes branch from d1cc825 to 81c5c8f Compare December 13, 2024 11:36

ccharly changed the title ~~Feat/keyring account scopes~~ feat(keyring-api)!: add scopes field to KeyringAccount Dec 13, 2024

ccharly mentioned this pull request Dec 13, 2024

feat!: add scopes field to KeyringAccount MetaMask/core#5066

Merged

4 tasks

ccharly force-pushed the feat/keyring-account-scopes branch from ecb5bc1 to 3a72085 Compare December 13, 2024 17:12

fix: add resolution for keyring-snap-client

98e9e2d

ccharly changed the title ~~feat(keyring-api)!: add scopes field to KeyringAccount~~ feat: add scopes field to KeyringAccount Jan 6, 2025

chore: update resolutions

670e89a

ccharly force-pushed the feat/keyring-account-scopes branch from d99ca87 to 670e89a Compare January 6, 2025 17:50

ccharly added 2 commits January 7, 2025 10:02

chore: lint + dedupe

59e5bde

chore: lavamost:auto

8a91bc6

Update LavaMoat policies

57e5b2d

fix: missing scopes in test + force type in migration 105

840eef9

ccharly force-pushed the feat/keyring-account-scopes branch from 1385544 to 840eef9 Compare January 7, 2025 13:50

ccharly added 6 commits January 7, 2025 21:53

chore: rename account.scopes migration (135 -> 136)

1cd78ab

Merge branch 'main' into feat/keyring-account-scopes

c3e5137

fix: disable forced migration

c628911

test(user-ops): use [email protected]

7b62692

Revert "chore: add local bitcoin snap (hack, needs to be removed)"

74aba6a

This reverts commit 370f06e.

test(btc): use [email protected]

4a19134

ccharly added 2 commits January 9, 2025 09:30

test(btc): update privacy snapshot + mock sat protection service

393f6e8

test(btc): fix BTC balance mocking when Sat Protection is enabled

b3d4ae8

ccharly added 3 commits January 9, 2025 16:11

chore: update resolutions

117e74a

test(sol): use [email protected]

77e5f17

chore: lint

6918983

ccharly force-pushed the feat/keyring-account-scopes branch from af16a23 to 6918983 Compare January 9, 2025 15:12

Merge branch 'main' into feat/keyring-account-scopes

49a676b

chore: update privacy-snapshot.json for solana support

400d2d3

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add `scopes` field to `KeyringAccount` #29195

feat: add `scopes` field to `KeyringAccount` #29195

ccharly commented Dec 13, 2024 •

edited

Loading

github-actions bot commented Dec 13, 2024

socket-security bot commented Dec 13, 2024 •

edited

Loading

ccharly commented Jan 7, 2025

metamaskbot commented Jan 7, 2025

socket-security bot commented Jan 8, 2025 •

edited

Loading

ccharly commented Jan 9, 2025

metamaskbot commented Jan 9, 2025

ccharly commented Jan 9, 2025

metamaskbot commented Jan 9, 2025

feat: add scopes field to KeyringAccount #29195

Are you sure you want to change the base?

feat: add scopes field to KeyringAccount #29195

Conversation

ccharly commented Dec 13, 2024 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Dec 13, 2024

socket-security bot commented Dec 13, 2024 • edited Loading

ccharly commented Jan 7, 2025

metamaskbot commented Jan 7, 2025

socket-security bot commented Jan 8, 2025 • edited Loading

Next steps

ccharly commented Jan 9, 2025

metamaskbot commented Jan 9, 2025

ccharly commented Jan 9, 2025

metamaskbot commented Jan 9, 2025

feat: add `scopes` field to `KeyringAccount` #29195

feat: add `scopes` field to `KeyringAccount` #29195

ccharly commented Dec 13, 2024 •

edited

Loading

socket-security bot commented Dec 13, 2024 •

edited

Loading

socket-security bot commented Jan 8, 2025 •

edited

Loading