Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding more metrics parameters for signature decoding #29197

Merged
merged 4 commits into from
Jan 8, 2025

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Dec 13, 2024

Description

Adding more parameters to signature decoding metrics:

  1. decoding_latency - this should capture the amount time it takes to display the decoding results to users. This is similar to the existing simulation_latency property for simulations.
  2. decoding_description - this should capture any error message sent along by the API. This is similar to how security_alerts_description property works for blockaid.
  3. decoding_in_progress - this value should be passed to decoding_response property when the user approves or rejects the signature request before we display the decoding output.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3778

Manual testing steps

  1. Enable metrics locally, go to test dapp
  2. Submit permit sign
  3. Check metrics for signature

Screenshots/Recordings

NA

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added the team-confirmations Push issues to confirmations team label Dec 13, 2024
@jpuri jpuri requested a review from a team as a code owner December 13, 2024 13:25
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [8a3cf34]
Page Load Metrics (1732 ± 45 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1531187717359646
domContentLoaded1521185617129043
load1530186617329445
domInteractive24103512512
backgroundConnect95923157
firstReactRender1674442512
getState46715188
initialActions01000
loadScripts1118141212887938
setupStore65310105
uiStartup17682139197210350
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 423 Bytes (0.01%)
  • common: 0 Bytes (0.00%)

@jpuri jpuri added this pull request to the merge queue Jan 8, 2025
Merged via the queue into main with commit e5ff471 Jan 8, 2025
77 checks passed
@jpuri jpuri deleted the sign_decoding_metrics branch January 8, 2025 10:30
@github-actions github-actions bot locked and limited conversation to collaborators Jan 8, 2025
@metamaskbot metamaskbot added the release-12.11.0 Issue or pull request that will be included in release 12.11.0 label Jan 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.11.0 Issue or pull request that will be included in release 12.11.0 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants