-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: [POM] Dapp subscribe network switch spec migration #29346
Merged
Merged
+105
−95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
seaona
added
e2e-test
End to end test for the MetaMask extension
area-qa
Relating to QA work (Quality Assurance)
labels
Dec 19, 2024
seaona
changed the title
spec migration
test: [POM] Dapp subscribe network switch spec migration
Dec 19, 2024
Builds ready [5ae20ff]
Page Load Metrics (1677 ± 53 ms)
Bundle size diffs
|
Builds ready [38f16f7]
Page Load Metrics (1736 ± 96 ms)
Bundle size diffs
|
chloeYue
approved these changes
Dec 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for clarifying the scenario!
jiexi
approved these changes
Dec 19, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Dec 20, 2024
metamaskbot
added
the
release-12.11.0
Issue or pull request that will be included in release 12.11.0
label
Dec 20, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area-qa
Relating to QA work (Quality Assurance)
e2e-test
End to end test for the MetaMask extension
release-12.11.0
Issue or pull request that will be included in release 12.11.0
team-extension-platform
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR migrates the
test/e2e/tests/request-queuing/dapp1-subscribe-network-switch.spec.js
spec to use page object model and typescript. It also updates the assertions to test what it's intended.Related issues
Fixes: #29348
Manual testing steps
Screenshots/Recordings
Messages when we console log them in the spec
This is the flow that happens in the spec, done manually.
subscribe-flow-spec.mp4
Pre-merge author checklist
Pre-merge reviewer checklist