Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: UI is not displaying gas limit set by dapp #29352

Merged
merged 2 commits into from
Dec 20, 2024
Merged

fix: UI is not displaying gas limit set by dapp #29352

merged 2 commits into from
Dec 20, 2024

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Dec 19, 2024

Description

UI is not displaying correct gas limit set by dapp. It always displays 21000.

Related issues

Fixes: #18417

Manual testing steps

  1. Submit confirmation request with gas limit not 21000
  2. Check gas limit in gas editing popup

Screenshots/Recordings

Screenshot 2024-12-19 at 7 20 45 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added the team-confirmations Push issues to confirmations team label Dec 19, 2024
@jpuri jpuri requested a review from a team as a code owner December 19, 2024 13:51
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [4dcc110]
Page Load Metrics (1735 ± 75 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint29121711586446214
domContentLoaded14662112170814770
load14762154173515775
domInteractive239542199
backgroundConnect10102252311
firstReactRender1698433416
getState574182110
initialActions00000
loadScripts10631694127413967
setupStore692283115
uiStartup171227252148268129
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 132 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@jpuri jpuri added this pull request to the merge queue Dec 20, 2024
Merged via the queue into main with commit a33f526 Dec 20, 2024
77 checks passed
@jpuri jpuri deleted the gas_limit_fix branch December 20, 2024 10:32
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2024
@metamaskbot metamaskbot added the release-12.11.0 Issue or pull request that will be included in release 12.11.0 label Dec 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.11.0 Issue or pull request that will be included in release 12.11.0 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Gas Limit value suggested from a Dapp is not respected, defaulting always to 21000
4 participants