Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ink Networks #29368

Closed
wants to merge 8 commits into from
Closed

Conversation

alexanderbradshaw
Copy link

@alexanderbradshaw alexanderbradshaw commented Dec 19, 2024

Description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Add Ink network according to (network information)[https://docs.inkonchain.com/general/network-information] and ensure ink.svg is displayed properly
  2. Add Ink Sepolia network according to (network information)[https://docs.inkonchain.com/general/network-information] and ensure ink-sepolia.svg is supported

Screenshots/Recordings

Before

Screenshot 2024-12-19 at 3 35 46 PM

After

Screenshot 2024-12-19 at 3 35 12 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Dec 19, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@alexanderbradshaw
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@salimtb
Copy link
Contributor

salimtb commented Jan 8, 2025

another PR with conventional commit has been created here

@salimtb salimtb closed this Jan 8, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jan 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants