Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add the new policy.json review process documentation and config #29383

Merged
merged 3 commits into from
Jan 8, 2025

Conversation

naugtur
Copy link
Contributor

@naugtur naugtur commented Dec 20, 2024

Description

Introducing the document outlining policy review process.

The current change to CODEOWNERS doesn't remove the all devs group - this makes it a soft-launch of the process where a specific approving review is not yet mandatory.

We'll be releasing a training video early January.

After merging this, I'm hoping to reference the document in multiple places to aid people in discovering and following the process.

Open in GitHub Codespaces

Related issues

Fixes: lack of attention to policy updates

Manual testing steps

  1. Follow the process and experience joy

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [fe9af48]
Page Load Metrics (1558 ± 59 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint13632015156113264
domContentLoaded13481928152912058
load13671962155812259
domInteractive2085382010
backgroundConnect106329199
firstReactRender1573322211
getState44912126
initialActions00000
loadScripts1001144911489043
setupStore620831
uiStartup15182194175713062
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@naugtur naugtur marked this pull request as ready for review January 7, 2025 09:43
@naugtur naugtur requested a review from a team as a code owner January 7, 2025 09:43
@metamaskbot
Copy link
Collaborator

Builds ready [4149303]
Page Load Metrics (1714 ± 61 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15221925171512359
domContentLoaded14901911168811857
load14961928171412661
domInteractive22200514220
backgroundConnect873292210
firstReactRender16106563618
getState475222612
initialActions01000
loadScripts10601476127511455
setupStore691263015
uiStartup170627162091306147

@naugtur
Copy link
Contributor Author

naugtur commented Jan 7, 2025

Hey, @MetaMask/policy-reviewers would you mind approving the PR that establishes the use of the group? 😄

Mrtenz
Mrtenz previously approved these changes Jan 8, 2025
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just one minor correction

Co-authored-by: Mark Stacey <[email protected]>
@naugtur naugtur dismissed stale reviews from Prithpal-Sooriya and Mrtenz via bb0fc60 January 8, 2025 13:47
@naugtur naugtur requested a review from Gudahtt January 8, 2025 13:47
@naugtur naugtur enabled auto-merge January 8, 2025 13:51
@metamaskbot
Copy link
Collaborator

Builds ready [bb0fc60]
Page Load Metrics (1695 ± 68 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15302017170313665
domContentLoaded15241986166413062
load15292023169514268
domInteractive2598452412
backgroundConnect8108333014
firstReactRender17173494019
getState586282713
initialActions01000
loadScripts1113145212268943
setupStore624942
uiStartup173626872030262126

@naugtur naugtur added this pull request to the merge queue Jan 8, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 8, 2025
@Gudahtt Gudahtt added this pull request to the merge queue Jan 8, 2025
Merged via the queue into main with commit ae565bc Jan 8, 2025
76 checks passed
@Gudahtt Gudahtt deleted the naugtur/introduce-policy-review-process branch January 8, 2025 19:20
@github-actions github-actions bot locked and limited conversation to collaborators Jan 8, 2025
@metamaskbot metamaskbot added the release-12.11.0 Issue or pull request that will be included in release 12.11.0 label Jan 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.11.0 Issue or pull request that will be included in release 12.11.0 team-lavamoat
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants