-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add the new policy.json review process documentation and config #29383
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [fe9af48]
Page Load Metrics (1558 ± 59 ms)
Bundle size diffs
|
Builds ready [4149303]
Page Load Metrics (1714 ± 61 ms)
|
Hey, @MetaMask/policy-reviewers would you mind approving the PR that establishes the use of the group? 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just one minor correction
Co-authored-by: Mark Stacey <[email protected]>
Builds ready [bb0fc60]
Page Load Metrics (1695 ± 68 ms)
|
Description
Introducing the document outlining policy review process.
The current change to CODEOWNERS doesn't remove the all devs group - this makes it a soft-launch of the process where a specific approving review is not yet mandatory.
We'll be releasing a training video early January.
After merging this, I'm hoping to reference the document in multiple places to aid people in discovering and following the process.
Related issues
Fixes: lack of attention to policy updates
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist