-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: [POM] Migrate connections e2e tests to TS and Page Object Model #29384
Merged
+216
−249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chloeYue
added
team-extension-platform
e2e-test
End to end test for the MetaMask extension
labels
Dec 20, 2024
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
chloeYue
changed the title
test: Chloe connections tests
test: [POM] Migrate connections e2e tests to TS and Page Object Model
Dec 20, 2024
Builds ready [955d3fe]
Page Load Metrics (1674 ± 54 ms)
Bundle size diffs
|
seaona
reviewed
Jan 8, 2025
seaona
reviewed
Jan 8, 2025
seaona
reviewed
Jan 8, 2025
seaona
reviewed
Jan 8, 2025
seaona
previously approved these changes
Jan 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good. Added a couple of small comments, but non-blocking
Builds ready [bcbf4b5]
Page Load Metrics (1650 ± 59 ms)
|
seaona
approved these changes
Jan 8, 2025
DDDDDanica
approved these changes
Jan 9, 2025
metamaskbot
added
the
release-12.11.0
Issue or pull request that will be included in release 12.11.0
label
Jan 9, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
e2e-test
End to end test for the MetaMask extension
release-12.11.0
Issue or pull request that will be included in release 12.11.0
team-extension-platform
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove the spec
test/e2e/tests/connections/connect-with-metamask.spec.js
as it's already completely tested in another spec. We don't want to repeat testing.create more class methods for permission page class
Related issues
Fixes: #29440
Manual testing steps
Check code readability, make sure tests pass.
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist