Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(29226): fix error for undefined unitInput for sending NFT #29386

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

DDDDDanica
Copy link
Contributor

@DDDDDanica DDDDDanica commented Dec 20, 2024

Description

When switching to another non-ERC721 NFT in send flow, it is possible that the input is undefined when rendered. As we didn't need to use scrollTo for this input (introduced here) , putting a conditional running is sufficient.

Open in GitHub Codespaces

Related issues

Fixes: #29226

Manual testing steps

  1. Go to NFT
  2. Pick a non ERC721 NFT to send
  3. Should not see errors in console when in the sending form

Screenshots/Recordings

Before

29226.-.NFT.Send.-.Before.mp4

After

29226.-.NFT.Send.-.After.mp4

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [6d23ac8]
Page Load Metrics (1870 ± 103 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint21922151704500240
domContentLoaded147821931848210101
load149222191870215103
domInteractive23102432512
backgroundConnect87024178
firstReactRender15112493115
getState571212110
initialActions01000
loadScripts10941713137917886
setupStore779252311
uiStartup172430612198313150
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 42 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link
Contributor

@dbrans dbrans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Merged via the queue into main with commit 29cbe95 Dec 20, 2024
82 checks passed
@DDDDDanica DDDDDanica deleted the fix/29226-nft-scrollTo branch December 20, 2024 15:16
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2024
@metamaskbot metamaskbot added the release-12.11.0 Issue or pull request that will be included in release 12.11.0 label Dec 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.11.0 Issue or pull request that will be included in release 12.11.0 team-extension-platform
Projects
Archived in project
5 participants