Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hide you received until bridge tx done #29411

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

infiniteflower
Copy link
Contributor

@infiniteflower infiniteflower commented Dec 20, 2024

Description

Open in GitHub Codespaces

This PR fixes an issue where the "You Received" row in the Activity item for a bridge tx would be partially filled in. Now we just hide it until the bridge tx completes and we have all the necessary data to display the row properly.

Related issues

Fixes:

Manual testing steps

  1. Start a bridge tx
  2. Get navigated to Activity list
  3. Click on bridge tx
  4. Observe that "You received" is not present until the bridge is completed.

Screenshots/Recordings

Before

After

Screen.Recording.2024-12-20.at.4.31.37.PM.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [f1147c3]
Page Load Metrics (1670 ± 57 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint23419801605335161
domContentLoaded14961959164712158
load15071972167011957
domInteractive24101372010
backgroundConnect95526147
firstReactRender1694312412
getState583172010
initialActions00000
loadScripts11151497124310550
setupStore65622209
uiStartup168327941939256123
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 32 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@infiniteflower infiniteflower marked this pull request as ready for review January 7, 2025 15:47
@infiniteflower infiniteflower requested a review from a team as a code owner January 7, 2025 15:47
@infiniteflower infiniteflower added this pull request to the merge queue Jan 7, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 7, 2025
@infiniteflower infiniteflower added this pull request to the merge queue Jan 7, 2025
Merged via the queue into main with commit 9deeadd Jan 7, 2025
89 checks passed
@infiniteflower infiniteflower deleted the mb1834-xchain-you-received branch January 7, 2025 18:05
@github-actions github-actions bot locked and limited conversation to collaborators Jan 7, 2025
@metamaskbot metamaskbot added the release-12.11.0 Issue or pull request that will be included in release 12.11.0 label Jan 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.11.0 Issue or pull request that will be included in release 12.11.0 team-swaps
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants