Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correct theme value for Snap UI footer buttons #29434

Merged
merged 2 commits into from
Jan 6, 2025

Conversation

FrederikBolding
Copy link
Member

@FrederikBolding FrederikBolding commented Jan 6, 2025

Description

The Snap UI footer buttons use the DS button which forces light theme, this does not work for the colors used in the Snap buttons, therefore we revert back to using the actually selected theme.

Open in GitHub Codespaces

Related issues

Fixes: #29388

Screenshots/Recordings

Before

Image

After

image

@FrederikBolding FrederikBolding requested a review from a team as a code owner January 6, 2025 10:22
@metamaskbot metamaskbot added team-snaps-platform Snaps Platform team INVALID-PR-TEMPLATE PR's body doesn't match template labels Jan 6, 2025
GuillaumeRx
GuillaumeRx previously approved these changes Jan 6, 2025
Mrtenz
Mrtenz previously approved these changes Jan 6, 2025
@FrederikBolding FrederikBolding dismissed stale reviews from Mrtenz and GuillaumeRx via 385b244 January 6, 2025 10:47
@metamaskbot
Copy link
Collaborator

Builds ready [385b244]
Page Load Metrics (1897 ± 57 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint56922141825314151
domContentLoaded16662147186311756
load16832199189711957
domInteractive29127562814
backgroundConnect1095332512
firstReactRender18103583215
getState688413215
initialActions01000
loadScripts1238164213949746
setupStore75816167
uiStartup198327452285218104

@FrederikBolding FrederikBolding added this pull request to the merge queue Jan 6, 2025
Merged via the queue into main with commit 1fbb63c Jan 6, 2025
79 checks passed
@FrederikBolding FrederikBolding deleted the fb/fix-snap-ui-footer-button-color branch January 6, 2025 11:54
@github-actions github-actions bot locked and limited conversation to collaborators Jan 6, 2025
@metamaskbot metamaskbot added the release-12.11.0 Issue or pull request that will be included in release 12.11.0 label Jan 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template release-12.11.0 Issue or pull request that will be included in release 12.11.0 team-snaps-platform Snaps Platform team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Snaps footer buttons colors are broken following updates to backgrounds
4 participants