Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(snaps): Scrollbar being partially hidden behind footer #29435

Merged
merged 5 commits into from
Jan 9, 2025

Conversation

GuillaumeRx
Copy link
Contributor

@GuillaumeRx GuillaumeRx commented Jan 6, 2025

Description

This fixes the scrollbar in Snap dialogs being partially hidden behind the footer.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

Screenshots/Recordings

Before

image
image

After

image
image

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@GuillaumeRx GuillaumeRx requested a review from a team as a code owner January 6, 2025 11:38
Copy link
Contributor

github-actions bot commented Jan 6, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-snaps-platform Snaps Platform team label Jan 6, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [5fcea01]
Page Load Metrics (1529 ± 49 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint13511742153710349
domContentLoaded1339172715169847
load13481740152910249
domInteractive217738199
backgroundConnect96116126
firstReactRender1572352211
getState45314168
initialActions01000
loadScripts963133811218440
setupStore644984
uiStartup15491990173410350

@GuillaumeRx GuillaumeRx force-pushed the gr/fix-overflow-scroll-bar branch from 7c8376c to ca89e23 Compare January 6, 2025 13:37
@metamaskbot
Copy link
Collaborator

Builds ready [ca89e23]
Page Load Metrics (1572 ± 34 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint30817471525288138
domContentLoaded1447170115526330
load1463170515727234
domInteractive2475452010
backgroundConnect77822189
firstReactRender15101342813
getState46419199
initialActions01000
loadScripts1046132311696129
setupStore66217199
uiStartup16222206183114168

@GuillaumeRx GuillaumeRx force-pushed the gr/fix-overflow-scroll-bar branch from ca89e23 to ec5f66f Compare January 7, 2025 14:12
@metamaskbot
Copy link
Collaborator

Builds ready [ec5f66f]
Page Load Metrics (1650 ± 48 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1456182716589847
domContentLoaded14041793162610149
load14481827165010048
domInteractive23119412412
backgroundConnect95427147
firstReactRender1582402512
getState55014126
initialActions01000
loadScripts1029134812128239
setupStore66217199
uiStartup16362035187112359

Copy link
Member

@Mrtenz Mrtenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work on macOS.

@FrederikBolding FrederikBolding added this pull request to the merge queue Jan 9, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 9, 2025
@GuillaumeRx GuillaumeRx added this pull request to the merge queue Jan 9, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 9, 2025
@GuillaumeRx GuillaumeRx added this pull request to the merge queue Jan 9, 2025
Merged via the queue into main with commit 3154019 Jan 9, 2025
76 checks passed
@GuillaumeRx GuillaumeRx deleted the gr/fix-overflow-scroll-bar branch January 9, 2025 14:13
@github-actions github-actions bot locked and limited conversation to collaborators Jan 9, 2025
@metamaskbot metamaskbot added the release-12.11.0 Issue or pull request that will be included in release 12.11.0 label Jan 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.11.0 Issue or pull request that will be included in release 12.11.0 team-snaps-platform Snaps Platform team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants