-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(snaps): Ensure that adjacent form elements take up to 50% width #29436
Merged
+49
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
david0xd
force-pushed
the
dd/snaps-ui-form-proportions
branch
from
January 6, 2025 12:28
30a38d3
to
be54210
Compare
Builds ready [be54210]
Page Load Metrics (1513 ± 49 ms)
|
GuillaumeRx
force-pushed
the
dd/snaps-ui-form-proportions
branch
from
January 7, 2025 14:12
be54210
to
58cb939
Compare
Builds ready [58cb939]
Page Load Metrics (1646 ± 76 ms)
|
david0xd
force-pushed
the
dd/snaps-ui-form-proportions
branch
from
January 8, 2025 12:41
d09322d
to
16abe03
Compare
Builds ready [16abe03]
Page Load Metrics (1653 ± 69 ms)
|
FrederikBolding
approved these changes
Jan 8, 2025
david0xd
force-pushed
the
dd/snaps-ui-form-proportions
branch
from
January 8, 2025 14:48
4f48b71
to
3838321
Compare
Builds ready [3838321]
Page Load Metrics (1904 ± 146 ms)
|
hmalik88
approved these changes
Jan 8, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jan 8, 2025
metamaskbot
added
the
release-12.11.0
Issue or pull request that will be included in release 12.11.0
label
Jan 8, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
release-12.11.0
Issue or pull request that will be included in release 12.11.0
team-snaps-platform
Snaps Platform team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add some SCSS changes to ensure that adjacent form elements take up to 50% width in Snaps custom UI.
Related issues
Fixes: MetaMask/snaps#2948
Manual testing steps
Snaps JSX used for testing:
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist