fix: Catch errors from the assets controller

[pedronfigueiredo]

Description

This PR addresses a group of errors reported on Sentry that occur when getTokenStandardAndDetails in assetsContractController returns "Unable to determine contract standard". Sentry Issue Link.

The error happens fairly often because only contracts that strictly adhere to the standard ABIs for ERC20, ERC721, and ERC1155 are correctly parsed. When a contract does not conform to these standards, the function fails and throws an error.

This PR introduces error handling to catch and silence the error when assetsContractController.getTokenStandardAndDetails fails to determine the contract standard. The control flow of the function is adjusted to ensure it continues to execute normally even when the error is caught.

Changes

• Added a try...catch block around the assetsContractController.getTokenStandardAndDetails call to catch and log the error.

• Ensured that the function continues to execute and return appropriate details even when the error is caught.

Related issues

Fixes: #25212

Manual testing steps

1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [8490727]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7
  • common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 12, 13, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1850 ± 105 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	434	2557	1796	384	184
		domContentLoaded	1606	2460	1822	218	104
		load	1613	2478	1850	218	105
		domInteractive	26	275	62	55	26
		backgroundConnect	9	82	30	20	10
		firstReactRender	17	100	44	31	15
		getState	5	86	21	23	11
		initialActions	0	1	0	0	0
		loadScripts	1172	1801	1361	163	78
		setupStore	7	79	23	24	12
		uiStartup	1849	2854	2195	297	143

[matthewwalsh0]

Is it worth an error if this is common, could we also do a warn as below?

[metamaskbot]

Builds ready [72425b3]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7
  • common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 12, 13, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2134 ± 147 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	224	2904	1800	771	370
		domContentLoaded	1741	2798	2092	285	137
		load	1790	2898	2134	305	147
		domInteractive	27	146	63	36	17
		backgroundConnect	7	99	38	27	13
		firstReactRender	16	106	52	30	14
		getState	6	64	25	17	8
		initialActions	0	57	3	12	6
		loadScripts	1300	2260	1587	244	117
		setupStore	7	87	19	22	11
		uiStartup	2042	3178	2532	374	179