feat: Add new completion_time_onchain property to Transaction Finalized events #29474
+95
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
pedronfigueiredo
changed the title
completion_time_onchain property to Transaction Finalized events
pedronfigueiredo
changed the title
completion_time_onchain property to Transaction Finalized events
pedronfigueiredo
force-pushed
the
pnf/3503
branch
from
673ca86 to
af59f40
Compare
Builds ready [af59f40]
Page Load Metrics (1837 ± 182 ms)
|
matthewwalsh0
previously approved these changes
Jan 7, 2025
pedronfigueiredo
force-pushed
the
pnf/3503
branch
2 times, most recently
from
03f5006 to
be72aa4
Compare
Builds ready [be72aa4]
Page Load Metrics (1546 ± 42 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
matthewwalsh0
requested changes
Jan 10, 2025
| @@ -828,6 +829,67 @@ describe('Transaction metrics', () => { | |||
| mockTransactionMetricsRequest.finalizeEventFragment, | |||
| ).toHaveBeenCalledWith(expectedUniqueId); | |||
| }); | |||
|
|
|||
| it.only('should create, update, finalize event fragment with completion_time_onchain', async () => { | |||
|
|
||
| const blockTimestampSeconds = Number(hexToDecimal(blockTimestampHex)); | ||
| const completionTimeSeconds = blockTimestampSeconds - submittedTimeMs / 1000; | ||
| const completionTimeSecondsRoundedToThousands = |
There was a problem hiding this comment.
Should this be completionTimeSecondsRoundedToHundredths or even completionTimeSecondsRounded for simplicity?
pedronfigueiredo
force-pushed
the
pnf/3503
branch
from
be72aa4 to
0b99632
Compare
Builds ready [0b99632]
Page Load Metrics (1722 ± 73 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The new property
completion_time_onchainhas the number of seconds (rounded to the hundredths) between submitted time and the block timestamp.This number is necessarily lower than the previously existing
completion_timeproperty, which captures the time between block validation and UI finalization and depends on the polling interval.Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3503
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist