Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change alert modal copy #29475

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

fix: change alert modal copy #29475

wants to merge 7 commits into from

Conversation

vinistevam
Copy link
Contributor

@vinistevam vinistevam commented Jan 7, 2025

Description

This PR aims to update the copy of the alert modal (description).

Open in GitHub Codespaces

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3731

Manual testing steps

You need to trigger a Danger alert (resimulation, domain mismatch or signing or Submitting)

  1. Go to this the Test Dapp
  2. Trigger a request
  3. Acknowledge the Danger alert

Screenshots/Recordings

image

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@vinistevam vinistevam added the team-confirmations Push issues to confirmations team label Jan 7, 2025
Copy link
Contributor

github-actions bot commented Jan 7, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@vinistevam vinistevam marked this pull request as ready for review January 7, 2025 14:48
@metamaskbot
Copy link
Collaborator

Builds ready [1d07c23]
Page Load Metrics (1610 ± 48 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint14841883161210048
domContentLoaded1433183415849646
load14841880161010148
domInteractive226938178
backgroundConnect97130199
firstReactRender1691292311
getState55914157
initialActions00000
loadScripts1055139111728441
setupStore65112126
uiStartup16462120183213163

matthewwalsh0
matthewwalsh0 previously approved these changes Jan 7, 2025
jpuri
jpuri previously approved these changes Jan 8, 2025
Copy link
Contributor

@jpuri jpuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@vinistevam vinistevam dismissed stale reviews from jpuri and matthewwalsh0 via 5e5a36b January 8, 2025 09:29
@metamaskbot
Copy link
Collaborator

Builds ready [b443c64]
Page Load Metrics (1950 ± 89 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint32523531872400192
domContentLoaded15402254192418287
load15852278195018589
domInteractive2591572110
backgroundConnect9150263115
firstReactRender23104552813
getState796353014
initialActions01000
loadScripts11461764144815273
setupStore77818189
uiStartup181528212340278133

@vinistevam vinistevam enabled auto-merge January 10, 2025 09:08
@vinistevam vinistevam added this pull request to the merge queue Jan 10, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [960980e]
Page Load Metrics (1513 ± 47 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1341173215139947
domContentLoaded1329166214908943
load1338173115139847
domInteractive2285452110
backgroundConnect776222010
firstReactRender1568282010
getState46216209
initialActions01000
loadScripts948125411038340
setupStore65714178
uiStartup15081960170010751
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 0 Bytes (0.00%)
  • ui: -5 Bytes (-0.00%)
  • common: -27 Bytes (-0.00%)

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 10, 2025
@vinistevam vinistevam added this pull request to the merge queue Jan 10, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 10, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [bd45f70]
Page Load Metrics (1658 ± 72 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint14422095165914871
domContentLoaded14332070164314771
load14422092165815072
domInteractive24242494723
backgroundConnect74419115
firstReactRender1582452512
getState46712157
initialActions00000
loadScripts10331578122413464
setupStore66212147
uiStartup16922297188815775
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 0 Bytes (0.00%)
  • ui: -5 Bytes (-0.00%)
  • common: -27 Bytes (-0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants