test: fix flaky snap signature test #29480

pnarayanaswamy · 2025-01-07T17:03:14Z

Description

Related issues

Fixes: #29380

Manual testing steps

Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-01-07T17:03:28Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2025-01-08T11:12:38Z

Builds ready [180a903]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 13, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1618 ± 53 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1496	1874	1618	112	54
		domContentLoaded	1486	1803	1594	104	50
		load	1496	1834	1618	111	53
		domInteractive	25	176	45	37	18
		backgroundConnect	9	59	25	15	7
		firstReactRender	15	102	49	32	15
		getState	5	51	13	14	7
		initialActions	0	0	0	0	0
		loadScripts	1059	1359	1193	96	46
		setupStore	6	59	19	19	9
		uiStartup	1678	2756	1916	261	125

…xtension into fix-flaky-snaps-test

metamaskbot · 2025-01-08T13:03:16Z

Builds ready [065893f]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 13, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1749 ± 77 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1502	2075	1750	163	78
		domContentLoaded	1480	2030	1724	163	78
		load	1504	2077	1749	160	77
		domInteractive	23	129	43	23	11
		backgroundConnect	9	86	30	20	10
		firstReactRender	17	79	44	25	12
		getState	5	56	15	15	7
		initialActions	0	1	0	0	0
		loadScripts	1048	1594	1292	156	75
		setupStore	6	62	17	19	9
		uiStartup	1708	2365	1997	185	89

…xtension into fix-flaky-snaps-test

matthewwalsh0 · 2025-01-08T13:48:46Z

test/e2e/snaps/test-snap-siginsights.spec.js

@@ -175,8 +175,13 @@ describe('Test Snap Signature Insights', function () {
          // switch back to MetaMask window and switch to tx insights pane
          await driver.switchToWindowWithTitle(WINDOW_TITLES.Dialog);

+          await driver.waitForSelector(


Doesn't the below clickElementSafe also wait for the selector, or does it take so long we need to wait twice as long and we can't change the timeout?

The clickElementSafe waits for elementsLocated, while the selector is waiting for it to be visible both serve different purposes. When an element exists in the dom it does not necessarily mean it is visible/interactable on the page hence the extra check. Also the wait is an intelligent one, so as soon as the condition is met it moves on, so we don't really add any extra time to the test if the element is present. The timeout is just the max time it waits before failing.

Sorry for the confusion, I'm aware the timeout isn't fixed, I was asking if there was a big delay in the test meaning we needed to wait twice to generate a sufficient delay.

Out of scope for this PR, but if one method is silently checking visibility, and the other just whether it exists, perhaps we could benefit from a requireVisible property on clickElementSafe to minimise duplication like this.

Makes sense, I'll make that change in another PR.

metamaskbot · 2025-01-08T13:56:16Z

Builds ready [73d76e5]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 13, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1738 ± 60 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1522	2088	1738	122	59
		domContentLoaded	1507	1993	1700	116	56
		load	1522	2092	1738	124	60
		domInteractive	26	74	37	12	6
		backgroundConnect	11	90	37	23	11
		firstReactRender	16	107	51	35	17
		getState	4	95	22	27	13
		initialActions	0	0	0	0	0
		loadScripts	1115	1442	1252	84	40
		setupStore	7	53	13	13	6
		uiStartup	1758	2813	2090	275	132

metamaskbot · 2025-01-08T14:09:14Z

Builds ready [21517af]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 13, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1685 ± 45 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1537	1912	1682	95	46
		domContentLoaded	1523	1898	1655	90	43
		load	1543	1919	1685	93	45
		domInteractive	21	94	36	19	9
		backgroundConnect	10	95	32	24	11
		firstReactRender	16	163	52	40	19
		getState	5	71	19	20	9
		initialActions	0	1	0	0	0
		loadScripts	1107	1454	1245	87	42
		setupStore	6	84	30	31	15
		uiStartup	1775	2619	2087	260	125

metamaskbot · 2025-01-08T15:19:05Z

Builds ready [cc6dba9]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 13, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1883 ± 143 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	413	2681	1610	535	257
		domContentLoaded	1533	2592	1852	297	143
		load	1556	2651	1883	298	143
		domInteractive	22	136	49	31	15
		backgroundConnect	8	69	31	18	9
		firstReactRender	16	81	41	25	12
		getState	4	66	19	19	9
		initialActions	0	1	0	0	0
		loadScripts	1099	1939	1373	221	106
		setupStore	6	53	11	11	5
		uiStartup	1730	3081	2132	344	165

test: fix flaky snap signature test

69bafed

metamaskbot added the team-confirmations Push issues to confirmations team label Jan 7, 2025

pnarayanaswamy added 3 commits January 8, 2025 10:16

chore: increase delay

f1ac41e

chore: change selector for arrow

39d85fa

Merge branch 'main' into fix-flaky-snaps-test

180a903

pnarayanaswamy added 3 commits January 8, 2025 13:19

chore: reduce delay

8bfeb48

Merge branch 'fix-flaky-snaps-test' of github.com:MetaMask/metamask-e…

065893f

…xtension into fix-flaky-snaps-test

chore: remove ff job

0150013

pnarayanaswamy added 2 commits January 8, 2025 14:06

Merge branch 'main' into fix-flaky-snaps-test

73d76e5

Merge branch 'fix-flaky-snaps-test' of github.com:MetaMask/metamask-e…

21517af

…xtension into fix-flaky-snaps-test

pnarayanaswamy marked this pull request as ready for review January 8, 2025 13:34

pnarayanaswamy requested a review from a team as a code owner January 8, 2025 13:34

matthewwalsh0 approved these changes Jan 8, 2025

View reviewed changes

Merge branch 'main' into fix-flaky-snaps-test

cc6dba9

Mrtenz approved these changes Jan 8, 2025

View reviewed changes

pnarayanaswamy enabled auto-merge January 8, 2025 15:09

pnarayanaswamy added this pull request to the merge queue Jan 8, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 8, 2025

pnarayanaswamy added this pull request to the merge queue Jan 8, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 8, 2025

pnarayanaswamy added this pull request to the merge queue Jan 8, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 8, 2025

pnarayanaswamy added this pull request to the merge queue Jan 9, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 9, 2025

pnarayanaswamy added this pull request to the merge queue Jan 9, 2025

Merged via the queue into main with commit ec75a8b Jan 9, 2025
77 checks passed

pnarayanaswamy deleted the fix-flaky-snaps-test branch January 9, 2025 08:46

github-actions bot locked and limited conversation to collaborators Jan 9, 2025

metamaskbot added the release-12.11.0 Issue or pull request that will be included in release 12.11.0 label Jan 9, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: fix flaky snap signature test #29480

test: fix flaky snap signature test #29480

pnarayanaswamy commented Jan 7, 2025 •

edited

Loading

github-actions bot commented Jan 7, 2025

metamaskbot commented Jan 8, 2025

metamaskbot commented Jan 8, 2025

matthewwalsh0 Jan 8, 2025

pnarayanaswamy Jan 8, 2025 •

edited

Loading

matthewwalsh0 Jan 8, 2025 •

edited

Loading

pnarayanaswamy Jan 9, 2025

metamaskbot commented Jan 8, 2025

metamaskbot commented Jan 8, 2025

metamaskbot commented Jan 8, 2025

test: fix flaky snap signature test #29480

test: fix flaky snap signature test #29480

Conversation

pnarayanaswamy commented Jan 7, 2025 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Jan 7, 2025

metamaskbot commented Jan 8, 2025

metamaskbot commented Jan 8, 2025

matthewwalsh0 Jan 8, 2025

Choose a reason for hiding this comment

pnarayanaswamy Jan 8, 2025 • edited Loading

Choose a reason for hiding this comment

matthewwalsh0 Jan 8, 2025 • edited Loading

Choose a reason for hiding this comment

pnarayanaswamy Jan 9, 2025

Choose a reason for hiding this comment

metamaskbot commented Jan 8, 2025

metamaskbot commented Jan 8, 2025

metamaskbot commented Jan 8, 2025

pnarayanaswamy commented Jan 7, 2025 •

edited

Loading

pnarayanaswamy Jan 8, 2025 •

edited

Loading

matthewwalsh0 Jan 8, 2025 •

edited

Loading