Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: crashing after bridge tx in Firefox #29631

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

infiniteflower
Copy link
Contributor

@infiniteflower infiniteflower commented Jan 10, 2025

Description

Open in GitHub Codespaces

This PR fixes an issue in Firefox only where the Extension would crash after submitting a bridge tx and would not be able to recover after a restart, forcing the user to wipe the Extension completely to fix it.

Related issues

Fixes: #29630

Manual testing steps

  1. If you have experienced this crash in FF before, start from a fresh install of the Extension
  2. Submit a bridge tx
  3. The app should not crash

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@infiniteflower infiniteflower marked this pull request as ready for review January 10, 2025 15:54
@infiniteflower infiniteflower requested a review from a team as a code owner January 10, 2025 15:54
jclancy93
jclancy93 previously approved these changes Jan 10, 2025
micaelae
micaelae previously approved these changes Jan 10, 2025
@infiniteflower infiniteflower dismissed stale reviews from micaelae and jclancy93 via 7cf80a0 January 10, 2025 16:14
ghgoodreau
ghgoodreau previously approved these changes Jan 10, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [e11652d]
Page Load Metrics (1682 ± 85 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint14792105168217483
domContentLoaded14192091164617283
load14802121168217785
domInteractive24125452512
backgroundConnect984342210
firstReactRender1699473316
getState580212211
initialActions01000
loadScripts10381633123815072
setupStore691242713
uiStartup165226502016263126
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 43 Bytes (0.00%)
  • ui: 146 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Extension crash on Firefox when Cross Chain swap
5 participants