Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Integrate snap background events #29641

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hmalik88
Copy link
Contributor

Description

Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions:

  1. What is the reason for the change? New background events feature.
  2. What is the improvement/solution? Added code to integrate the new feature.

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added team-snaps-platform Snaps Platform team INVALID-PR-TEMPLATE PR's body doesn't match template labels Jan 10, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [a0913f0]
Page Load Metrics (1501 ± 52 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint13601776150710751
domContentLoaded13201760148210852
load13611773150110852
domInteractive217534178
backgroundConnect86021168
firstReactRender1597433316
getState55518178
initialActions01000
loadScripts959132810989244
setupStore66410136
uiStartup15912117179515876
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 411 Bytes (0.01%)
  • ui: 203 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template team-snaps-platform Snaps Platform team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants