Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fixes the build folder name creation #1102

Merged
merged 2 commits into from
Oct 28, 2024
Merged

fix: fixes the build folder name creation #1102

merged 2 commits into from
Oct 28, 2024

Conversation

christopherferreira9
Copy link
Collaborator

Explanation

Fixes an issue where a debug echo would change a variable name.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@christopherferreira9 christopherferreira9 requested a review from a team as a code owner October 28, 2024 16:13
elefantel
elefantel approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@elefantel elefantel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christopherferreira9 christopherferreira9 merged commit deb60fb into main Oct 28, 2024
28 checks passed
@christopherferreira9 christopherferreira9 deleted the fix/fixes-deployment-folder branch October 28, 2024 16:20
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elefantel elefantel elefantel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@christopherferreira9 @elefantel