refactor(sdk): modernize wallet provider detection with EIP-6963

[abretonc7s]

Description

Overview

This PR modernizes our wallet provider detection by prioritizing the EIP-6963 standard while maintaining backwards compatibility. It simplifies our codebase by removing complex wallet-specific detection logic and improves reliability across different browser environments, particularly on iOS.

Key Changes

• ✨ Prioritize EIP-6963 for wallet provider detection
• 🔥 Remove legacy wallet detection heuristics (flags like isMetaMask, isBraveWallet, etc.)
• 🛠️ Simplify fallback logic to use window.ethereum only when necessary
• 🐛 Add error handling for Brave iOS where window properties are read-only
• 📝 Improve test coverage and reduce test complexity

Technical Implementation

• Restructured provider detection flow:
  1. Attempt EIP-6963 provider detection first
  2. Fallback to window.ethereum only for non-MetaMask scenarios
  3. Throw clear error messages when no provider is found
• Added try-catch blocks around window modifications to handle read-only properties
• Removed ~70 lines of wallet-specific detection code
• Simplified test suite while maintaining coverage

Impact

Better

• More reliable wallet detection across browsers
• Cleaner codebase with less maintenance overhead
• Better compatibility with EIP-6963 compliant wallets
• More resilient error handling

Breaking Changes

None. This change maintains backward compatibility while improving the primary detection path.

Testing Instructions

1. Test with different wallet configurations:

   • MetaMask only
   • Multiple wallets installed (e.g., MetaMask + Coinbase)
   • Non-MetaMask wallets

2. Test on different platforms:

   • Desktop browsers (Chrome, Firefox, Safari)
   • Mobile browsers
   • Brave browser (especially iOS)

Special Considerations

• This change relies on the EIP-6963 standard. While we maintain fallback support, modern wallets should be encouraged to implement this standard
• Brave iOS users may see logged warnings about read-only properties, this is expected and handled gracefully

[codecov]

Codecov Report

Attention: Patch coverage is 53.84615% with 6 lines in your changes missing coverage. Please review.

Project coverage is 76.99%. Comparing base (655a7be) to head (aec4551).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
packages/sdk/src/services/Ethereum.ts	25.00%	6 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1126      +/-   ##
==========================================
- Coverage   77.16%   76.99%   -0.17%     
==========================================
  Files         180      180              
  Lines        4256     4238      -18     
  Branches     1048     1039       -9     
==========================================
- Hits         3284     3263      -21     
- Misses        972      975       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[christopherferreira9]

LGTM