Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: removes extensionOnly from the web3onboard example #1149

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

christopherferreira9
Copy link
Collaborator

Explanation

This PR removes extensionOnly option from the SDK options since it is redundant.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@christopherferreira9 christopherferreira9 requested a review from a team as a code owner November 27, 2024 16:05
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.14%. Comparing base (8ab1cf1) to head (43ccc34).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1149      +/-   ##
==========================================
- Coverage   74.26%   74.14%   -0.12%     
==========================================
  Files         181      181              
  Lines        4297     4297              
  Branches     1052     1052              
==========================================
- Hits         3191     3186       -5     
- Misses       1106     1111       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant